Miscellaneous changes to the migration assessment #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that we can easily concat reason and suggestion for assessmetn
| // formatToRegex converts a format string containing %s and %v | ||
| // into a regex pattern. | ||
| // - %s => (.+?) (capturing group) | ||
| // - %v => (?:.+?) (non-capturing group) |
There was a problem hiding this comment.
wouldn't the existing implementation work? (since you were only checking for %s)? Why even define a group for %v?
There was a problem hiding this comment.
No, what we are doing is in the description variables replacing format specifier with this regexp pattern - .+?
so that it can match the final desc string formed after putting those values. and then replace these captured substring with XXX
But where %v is used, that need to be there so matching of regexp can happen(formattedDesc vs finalDesc) but no need to capture that or replace that with XXX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
Clearly demarcation between the value of description and suggestion fields
Added fullstop to all the issue descriptions or reasons
Describe if there are any user-facing changes
NO
How was this pull request tested?
Exisitng tests are enough, updating the static text in them wherever required.
Does your PR have changes that can cause upgrade issues?