Miscellaneous changes to the migration assessment (#2212)

* Allowing type but not object name(column/table) in Reason to send to callhome

* Removed redundant info from Suggestion for policies issue
* Added fullstop to all the issue descriptions or reasons
   - so that we can easily concat reason and suggestion for assessment
* Concatenate description and suggestion for AssessmentIssue.Description field

migtests/tests/pg/pgtbrus/expected_files/expected_schema_analysis_report.json

@@ -63,7 +63,7 @@
             "IssueType": "migration_caveats",
             "ObjectType": "FOREIGN TABLE",
             "ObjectName": "public.f_c",
-            "Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager. These should be manually created to make the foreign tables work.",
+            "Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager.",
             "SqlStatement": "CREATE FOREIGN TABLE public.f_c (     i integer NOT NULL,     t integer,     x text ) SERVER p10 OPTIONS (     table_name 'c' );",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/pgtbrus/export-dir/schema/tables/foreign_table.sql",
             "Suggestion": "SERVER 'p10', and USER MAPPING should be created manually on the target to create and use the foreign table",
@@ -75,7 +75,7 @@
             "IssueType": "migration_caveats",
             "ObjectType": "FOREIGN TABLE",
             "ObjectName": "public.f_t",
-            "Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager. These should be manually created to make the foreign tables work.",
+            "Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager.",
             "SqlStatement": "CREATE FOREIGN TABLE public.f_t (     i integer NOT NULL,     ts timestamp(0) with time zone DEFAULT now(),     j json,     t text,     e public.myenum,     c public.mycomposit ) SERVER p10 OPTIONS (     table_name 't' );",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/pgtbrus/export-dir/schema/tables/foreign_table.sql",
             "Suggestion": "SERVER 'p10', and USER MAPPING should be created manually on the target to create and use the foreign table",

migtests/tests/pg/sakila/expected_files/expected_schema_analysis_report.json

@@ -81,7 +81,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "TABLE",
             "ObjectName": "public.payment_p2007_01",
-            "Reason": "Table inheritance is not yet supported in YugabyteDB",
+            "Reason": "Table inheritance is not yet supported in YugabyteDB.",
             "SqlStatement": "CREATE TABLE public.payment_p2007_01 (\n    CONSTRAINT payment_p2007_01_payment_date_check CHECK (((payment_date \u003e= '2007-01-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-02-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
             "Suggestion": "",
@@ -105,7 +105,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "TABLE",
             "ObjectName": "public.payment_p2007_02",
-            "Reason": "Table inheritance is not yet supported in YugabyteDB",
+            "Reason": "Table inheritance is not yet supported in YugabyteDB.",
             "SqlStatement": "CREATE TABLE public.payment_p2007_02 (\n    CONSTRAINT payment_p2007_02_payment_date_check CHECK (((payment_date \u003e= '2007-02-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-03-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
             "Suggestion": "",
@@ -117,7 +117,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "TABLE",
             "ObjectName": "public.payment_p2007_03",
-            "Reason": "Table inheritance is not yet supported in YugabyteDB",
+            "Reason": "Table inheritance is not yet supported in YugabyteDB.",
             "SqlStatement": "CREATE TABLE public.payment_p2007_03 (\n    CONSTRAINT payment_p2007_03_payment_date_check CHECK (((payment_date \u003e= '2007-03-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-04-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
             "Suggestion": "",
@@ -129,7 +129,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "TABLE",
             "ObjectName": "public.payment_p2007_04",
-            "Reason": "Table inheritance is not yet supported in YugabyteDB",
+            "Reason": "Table inheritance is not yet supported in YugabyteDB.",
             "SqlStatement": "CREATE TABLE public.payment_p2007_04 (\n    CONSTRAINT payment_p2007_04_payment_date_check CHECK (((payment_date \u003e= '2007-04-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-05-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
             "Suggestion": "",
@@ -141,7 +141,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "TABLE",
             "ObjectName": "public.payment_p2007_05",
-            "Reason": "Table inheritance is not yet supported in YugabyteDB",
+            "Reason": "Table inheritance is not yet supported in YugabyteDB.",
             "SqlStatement": "CREATE TABLE public.payment_p2007_05 (\n    CONSTRAINT payment_p2007_05_payment_date_check CHECK (((payment_date \u003e= '2007-05-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-06-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
             "Suggestion": "",
@@ -153,7 +153,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "TABLE",
             "ObjectName": "public.payment_p2007_06",
-            "Reason": "Table inheritance is not yet supported in YugabyteDB",
+            "Reason": "Table inheritance is not yet supported in YugabyteDB.",
             "SqlStatement": "CREATE TABLE public.payment_p2007_06 (\n    CONSTRAINT payment_p2007_06_payment_date_check CHECK (((payment_date \u003e= '2007-06-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-07-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
             "Suggestion": "",

migtests/tests/pg/sample-is/expected_files/expected_schema_analysis_report.json

@@ -64,7 +64,7 @@
             "IssueType": "unsupported_features",
             "ObjectType": "TABLE",
             "ObjectName": "public.secret_missions, constraint: (cnt_solo_agent)",
-            "Reason": "Exclusion constraints are not yet supported in YugabyteDB",
+            "Reason": "Exclusion constraints are not yet supported in YugabyteDB.",
             "SqlStatement": "ALTER TABLE ONLY public.secret_missions\n    ADD CONSTRAINT cnt_solo_agent EXCLUDE USING gist (location WITH =, mission_timeline WITH \u0026\u0026);",
             "FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sample-is/export-dir/schema/tables/table.sql",
             "Suggestion": "Refer docs link for details on possible workaround",