Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous changes to the migration assessment #2212

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Miscellaneous changes to the migration assessment #2212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
90ea73a
Added fullstop to all the issue descriptions or reasons
sanyamsinghal Jan 21, 2025
72fb2ae
Removed redundant info from Suggestion for policies issue
sanyamsinghal Jan 21, 2025
b69de01
Concatenate description and suggestion for AssessmentIssue.Descriptio…
sanyamsinghal Jan 21, 2025
2857cef
Fixed expected Suggestion
sanyamsinghal Jan 21, 2025
2c986d3
Allowing type but not object name(column/table) in Reason to send to …
sanyamsinghal Jan 21, 2025
ba0f9dc
typo fix
sanyamsinghal Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 92 additions & 92 deletions migtests/tests/analyze-schema/expected_issues.json
View file
Open in desktop

Large diffs are not rendered by default.

136 changes: 68 additions & 68 deletions migtests/tests/pg/adventureworks/expected_files/expected_schema_analysis_report.json
View file
Open in desktop

Large diffs are not rendered by default.

214 changes: 107 additions & 107 deletions migtests/tests/pg/mgi/expected_files/expected_schema_analysis_report.json
View file
Open in desktop

Large diffs are not rendered by default.

70 changes: 35 additions & 35 deletions migtests/tests/pg/omnibus/expected_files/expected_schema_analysis_report.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions migtests/tests/pg/pgtbrus/expected_files/expected_schema_analysis_report.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"IssueType": "migration_caveats",
"ObjectType": "FOREIGN TABLE",
"ObjectName": "public.f_c",
"Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager. These should be manually created to make the foreign tables work.",
"Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager.",
"SqlStatement": "CREATE FOREIGN TABLE public.f_c ( i integer NOT NULL, t integer, x text ) SERVER p10 OPTIONS ( table_name 'c' );",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/pgtbrus/export-dir/schema/tables/foreign_table.sql",
"Suggestion": "SERVER 'p10', and USER MAPPING should be created manually on the target to create and use the foreign table",
Expand All @@ -75,7 +75,7 @@
"IssueType": "migration_caveats",
"ObjectType": "FOREIGN TABLE",
"ObjectName": "public.f_t",
"Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager. These should be manually created to make the foreign tables work.",
"Reason": "Foreign table creation fails as SERVER and USER MAPPING objects are not exported by voyager.",
"SqlStatement": "CREATE FOREIGN TABLE public.f_t ( i integer NOT NULL, ts timestamp(0) with time zone DEFAULT now(), j json, t text, e public.myenum, c public.mycomposit ) SERVER p10 OPTIONS ( table_name 't' );",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/pgtbrus/export-dir/schema/tables/foreign_table.sql",
"Suggestion": "SERVER 'p10', and USER MAPPING should be created manually on the target to create and use the foreign table",
Expand Down
220 changes: 110 additions & 110 deletions migtests/tests/pg/rna/expected_files/expected_schema_analysis_report.json
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions migtests/tests/pg/sakila/expected_files/expected_schema_analysis_report.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
"IssueType": "unsupported_features",
"ObjectType": "TABLE",
"ObjectName": "public.payment_p2007_01",
"Reason": "Table inheritance is not yet supported in YugabyteDB",
"Reason": "Table inheritance is not yet supported in YugabyteDB.",
"SqlStatement": "CREATE TABLE public.payment_p2007_01 (\n CONSTRAINT payment_p2007_01_payment_date_check CHECK (((payment_date \u003e= '2007-01-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-02-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
"Suggestion": "",
Expand All @@ -105,7 +105,7 @@
"IssueType": "unsupported_features",
"ObjectType": "TABLE",
"ObjectName": "public.payment_p2007_02",
"Reason": "Table inheritance is not yet supported in YugabyteDB",
"Reason": "Table inheritance is not yet supported in YugabyteDB.",
"SqlStatement": "CREATE TABLE public.payment_p2007_02 (\n CONSTRAINT payment_p2007_02_payment_date_check CHECK (((payment_date \u003e= '2007-02-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-03-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
"Suggestion": "",
Expand All @@ -117,7 +117,7 @@
"IssueType": "unsupported_features",
"ObjectType": "TABLE",
"ObjectName": "public.payment_p2007_03",
"Reason": "Table inheritance is not yet supported in YugabyteDB",
"Reason": "Table inheritance is not yet supported in YugabyteDB.",
"SqlStatement": "CREATE TABLE public.payment_p2007_03 (\n CONSTRAINT payment_p2007_03_payment_date_check CHECK (((payment_date \u003e= '2007-03-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-04-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
"Suggestion": "",
Expand All @@ -129,7 +129,7 @@
"IssueType": "unsupported_features",
"ObjectType": "TABLE",
"ObjectName": "public.payment_p2007_04",
"Reason": "Table inheritance is not yet supported in YugabyteDB",
"Reason": "Table inheritance is not yet supported in YugabyteDB.",
"SqlStatement": "CREATE TABLE public.payment_p2007_04 (\n CONSTRAINT payment_p2007_04_payment_date_check CHECK (((payment_date \u003e= '2007-04-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-05-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
"Suggestion": "",
Expand All @@ -141,7 +141,7 @@
"IssueType": "unsupported_features",
"ObjectType": "TABLE",
"ObjectName": "public.payment_p2007_05",
"Reason": "Table inheritance is not yet supported in YugabyteDB",
"Reason": "Table inheritance is not yet supported in YugabyteDB.",
"SqlStatement": "CREATE TABLE public.payment_p2007_05 (\n CONSTRAINT payment_p2007_05_payment_date_check CHECK (((payment_date \u003e= '2007-05-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-06-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
"Suggestion": "",
Expand All @@ -153,7 +153,7 @@
"IssueType": "unsupported_features",
"ObjectType": "TABLE",
"ObjectName": "public.payment_p2007_06",
"Reason": "Table inheritance is not yet supported in YugabyteDB",
"Reason": "Table inheritance is not yet supported in YugabyteDB.",
"SqlStatement": "CREATE TABLE public.payment_p2007_06 (\n CONSTRAINT payment_p2007_06_payment_date_check CHECK (((payment_date \u003e= '2007-06-01 00:00:00'::timestamp without time zone) AND (payment_date \u003c '2007-07-01 00:00:00'::timestamp without time zone)))\n)\nINHERITS (public.payment);",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sakila/export-dir/schema/tables/table.sql",
"Suggestion": "",
Expand Down
2 changes: 1 addition & 1 deletion migtests/tests/pg/sample-is/expected_files/expected_schema_analysis_report.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"IssueType": "unsupported_features",
"ObjectType": "TABLE",
"ObjectName": "public.secret_missions, constraint: (cnt_solo_agent)",
"Reason": "Exclusion constraints are not yet supported in YugabyteDB",
"Reason": "Exclusion constraints are not yet supported in YugabyteDB.",
"SqlStatement": "ALTER TABLE ONLY public.secret_missions\n ADD CONSTRAINT cnt_solo_agent EXCLUDE USING gist (location WITH =, mission_timeline WITH \u0026\u0026);",
"FilePath": "/home/ubuntu/yb-voyager/migtests/tests/pg/sample-is/export-dir/schema/tables/table.sql",
"Suggestion": "Refer docs link for details on possible workaround",
Expand Down
Loading