Add a note at type_inference.md for adding custom verifier if return type inference is not feasible #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdasgup3
reviewed
Apr 4, 2024
abhigunj
force-pushed
the
doc_verifier_placement
branch
from
7e71de6 to
a35ce65
Compare
ghpvnist
approved these changes
Apr 17, 2024
abhigunj
force-pushed
the
doc_verifier_placement
branch
from
f94d7ac to
eb242e9
Compare
GleasonK
approved these changes
Apr 17, 2024
abhigunj
force-pushed
the
doc_verifier_placement
branch
from
1806f1d to
9e85f80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if return type of the op is inferable, it can be created using
op::buildwhich does not take result type as input. For such ops it is recommended to move verification logic to shape functions to avoid missing on any verification during op creation. If return type inference is not feasible use custom verifier.