Skip to content

Commit

Permalink
added addop note
Browse files Browse the repository at this point in the history
  • Loading branch information
abhigunj committed Apr 17, 2024
1 parent a35ce65 commit eb242e9
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions docs/type_inference.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,10 @@ The solution is as follows:
1. **For most ops without regions** (like `PadOp`): Try to put all the verification
code into the shape functions, and discard verifiers totally. In cases where
this isn't possible due to the inability to infer return types
(such as with`ReshapeOp` or `BroadcastInDimOp`), create a custom verifier to
contain the necessary verification logic."
(such as with`ReshapeOp` or `BroadcastInDimOp`), create a verifier to
contain the necessary verification logic. Typically inferable ops,
like `AddOp`, may still need a verifier to perform additional verifications
when quantization is involved.

2. **For ops with regions** (like `ReduceOp/IfOp`; a full list is
[here](https://github.com/openxla/stablehlo/pull/401)): The autogenerated
Expand Down

0 comments on commit eb242e9

Please sign in to comment.