Skip to content

Commit

Permalink
Update type_inference.md
Browse files Browse the repository at this point in the history
  • Loading branch information
abhigunj authored Apr 23, 2024
1 parent eb242e9 commit 1806f1d
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions docs/type_inference.md
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,11 @@ The solution is as follows:
this isn't possible due to the inability to infer return types
(such as with`ReshapeOp` or `BroadcastInDimOp`), create a verifier to
contain the necessary verification logic. Typically inferable ops,
like `AddOp`, may still need a verifier to perform additional verifications
when quantization is involved.
like `AddOp`, may still need a verifier to perform additional verifications,
because they are verifying constraints of a provided return type, which
is not accessible in the type/shape inference methods.

2. **For ops with regions** (like `ReduceOp/IfOp`; a full list is
3. **For ops with regions** (like `ReduceOp/IfOp`; a full list is
[here](https://github.com/openxla/stablehlo/pull/401)): The autogenerated
builders don't take regions as parameters, so if these builders involve type
inference, then the shape function will be called with empty regions (see
Expand Down

0 comments on commit 1806f1d

Please sign in to comment.