Fix build_and_run_tests.sh command error. #1319
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, kudos to the OpenSpiel team for maintaining such an impressive and valuable framework for reinforcement learning and game theory research!
This PR addresses an issue with the
pybind11
dependency in OpenSpiel, stemming from thesmart_holder
branch being archived and renamed toarchive/smart_holder
in thepybind11
repository (see: https://github.com/pybind/pybind11/tree/archive/smart_holder). The original build process attempted to clone the now-deprecatedsmart_holder
branch, causing errors.Changes Made
pybind11
Branch: Modified thecached_clone
command in./open_spiel/scripts/build_and_run_tests.sh
to use themaster
branch ofpybind11
instead ofsmart_holder
orarchive/smart_holder
. Thesmart_holder
features are now fully integrated intomaster
, making this the appropriate target.pybind11
migration guidelines, removed the obsolete#include <pybind11/smart_holder.h>
and the following deprecated macros from the codebase:PYBIND11_SMART_HOLDER_TYPE_CASTERS
These are no longer needed with the latest
pybind11
.Result
These changes resolve the build errors encountered when running
./open_spiel/scripts/build_and_run_tests.sh
, ensuring compatibility with the currentpybind11
master
branch.Please review and let me know if additional adjustments are needed!