Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all smart_holder.h includes and PYBIND11_SMART_HOLDER_TYPE_CASTERS macros. #1317

Closed
wants to merge 1 commit into from

Conversation

rwgk
Copy link
Contributor

@rwgk rwgk commented Mar 6, 2025

Please refer to #1321

Please ignore this PR.

Original description:

The smart_holder.h include and the PYBIND11_SMART_HOLDER_TYPE_CASTERS macros were made obsolete by pybind/pybind11#5257 (merged on Jul 31, 2024).

Copy link

google-cla bot commented Mar 6, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@rwgk
Copy link
Contributor Author

rwgk commented Mar 6, 2025

@lanctot I believe these simple changes should work with:

If that's true, you will not have to do anything special in the future. For the moment, use pybind11 master floating. After the first pybind11 v3 release you can pin to releases if you wish.

…TERS macros.

The include and the PYBIND11_SMART_HOLDER_TYPE_CASTERS were made obsolete by pybind/pybind11#5257 (merged on Jul 31, 2024).
@rwgk rwgk force-pushed the remove_smart_holder_h branch from 0dc0532 to b44ccec Compare March 6, 2025 07:29
@rwgk rwgk closed this Mar 6, 2025
@rwgk rwgk deleted the remove_smart_holder_h branch March 6, 2025 07:32
@rwgk rwgk restored the remove_smart_holder_h branch March 6, 2025 07:32
@rwgk rwgk mentioned this pull request Mar 7, 2025
@rwgk rwgk deleted the remove_smart_holder_h branch March 7, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant