Please ignore.

[rwgk]

Please refer to #1321

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[rwgk]

Sorry it's stubbornly using my corporate email address for the CLA. I'll close this also. Could you please clone the diff?

[lanctot]

Look at this positive success of open-source software at work.. !! The thing broke so very recently, and @tsogoo submitted a fix independently. I'm so grateful for the help, thanks to both of you.

However: @rwgk, what I need more than this fix at the moment is the simplest way for OpenSpiel to co-exist internally + externally without having two different states of the code to maintain. So, for that reason I would prefer to pin OpenSpiel's dependency downloader to an old version of the code until the Python team at Google imports the recent changes to pybind11 (i.e. something like #1315).

So is it ok with you to keep this PR around until that happens? Meanwhile I'll contact the Python team internally to let them know that this solves it? Wdyt?

[rwgk]

However: @rwgk, what I need more than this fix at the moment is the simplest way for OpenSpiel to co-exist internally + externally without having two different states of the code to maintain.

That's what this PR is meant to be.

Sorry I didn't explain that here. Copying what I wrote in a chat:

First:

I'm AFK but will look later at what you have, atm I'm asking myself, could you simply remove smartholder.h includes and the obsolete macros, and it works externally with pybind11 master as is, and internally with google3 as is?

Later:

If the diff works as I hope, that will free you from having to worry about branches and commit hashes.

[rwgk]

My suggestion:

Run this CI here with this PR.

Apply the same diff internally.

If both work as I hope, submit internally and done.

[lanctot]

That's what this PR is meant to be.

Oh, cool!! Ok, sorry -- my bad. I've been traveling and only quickly read those messages and misunderstood.

Thanks so much! I'll follow the steps you've suggested.

[lanctot]

Ok, can you make the same change as to open_spiel/scripts/install.sh that was done in #1319 ?

[rwgk]

I got confused, too, I was thinking I'm writing my response under #1317 😅

And I see #1319 is yet another incarnation of the same change.

[rwgk]

@lanctot if it's not too late: ideally re-open #1319 and discard #1317 and #1318.