-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move object method bodies into a separate class when original class is too large #41409
Conversation
It is not good to always split the Ballerina classes because it will have unnecessary overhead. So we will only split if the jvm class will be too large (if it have more than 100 methods). In the PR, I have temperorily sent a commit to always split the class to find whether all the cases are passing for now. @NipunaRanasinghe Now the debugger tests will fail (https://scans.gradle.com/s/327ej7fmt3srq/tests/overview?outcome=FAILED). |
bvm/ballerina-runtime/src/main/java/io/ballerina/runtime/internal/values/ErrorValue.java
Show resolved
Hide resolved
Tested the fix with a service have about 400 resource functions, and it worked fine. |
This reverts commit 1b65578.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #41409 +/- ##
============================================
+ Coverage 76.71% 76.72% +0.01%
- Complexity 52667 52686 +19
============================================
Files 2880 2879 -1
Lines 198580 198651 +71
Branches 25801 25808 +7
============================================
+ Hits 152334 152421 +87
+ Misses 37812 37800 -12
+ Partials 8434 8430 -4 ☔ View full report in Codecov by Sentry. |
Sonarcloud scan is failing due to #41539. |
...er/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmValueGen.java
Show resolved
Hide resolved
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/MethodGen.java
Show resolved
Hide resolved
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/MethodGen.java
Show resolved
Hide resolved
compiler/ballerina-lang/src/main/java/io/ballerina/projects/JBallerinaBackend.java
Show resolved
Hide resolved
...ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmCodeGenUtil.java
Show resolved
Hide resolved
...er/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmValueGen.java
Outdated
Show resolved
Hide resolved
...er/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmValueGen.java
Outdated
Show resolved
Hide resolved
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/MethodGen.java
Outdated
Show resolved
Hide resolved
tests/jballerina-unit-test/src/test/resources/test-src/jvm/tooLargeFileTest/Ballerina.toml
Outdated
Show resolved
Hide resolved
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SonarCloud Quality Gate failed.
|
Purpose
$title
Fixes #41279
Approach
Samples
Remarks
Check List