-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2201.8.x] Move object method bodies into a separate class when original class is too large #41647
Merged
warunalakshitha
merged 22 commits into
ballerina-platform:2201.8.x
from
Nadeeshan96:8x-fix-file-too-large-41279
Nov 9, 2023
Merged
[2201.8.x] Move object method bodies into a separate class when original class is too large #41647
warunalakshitha
merged 22 commits into
ballerina-platform:2201.8.x
from
Nadeeshan96:8x-fix-file-too-large-41279
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b65578.
Nadeeshan96
added
the
Team/jBallerina
All the issues related to BIR, JVM backend code generation and runtime
label
Nov 6, 2023
Nadeeshan96
requested review from
warunalakshitha,
sameerajayasoma and
hasithaa
as code owners
November 6, 2023 04:35
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2201.8.x #41647 +/- ##
==============================================
+ Coverage 76.34% 76.36% +0.01%
- Complexity 52518 52537 +19
==============================================
Files 2881 2880 -1
Lines 198587 198669 +82
Branches 25802 25810 +8
==============================================
+ Hits 151615 151706 +91
+ Misses 38614 38612 -2
+ Partials 8358 8351 -7
☔ View full report in Codecov by Sentry. |
...lerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmInstructionGen.java
Show resolved
Hide resolved
...ang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/interop/ExternalMethodGen.java
Show resolved
Hide resolved
...ang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/interop/ExternalMethodGen.java
Show resolved
Hide resolved
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/MethodGen.java
Show resolved
Hide resolved
warunalakshitha
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title
Duplicate PR of #41409.
Fixes #41279
Approach
Samples
Remarks
Check List