Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2201.8.x] Move object method bodies into a separate class when original class is too large #41647

Conversation

Nadeeshan96
Copy link
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Duplicate PR of #41409.
Fixes #41279

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Nadeeshan96 Nadeeshan96 added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4951240) 76.34% compared to head (4d64855) 76.36%.
Report is 10 commits behind head on 2201.8.x.

Additional details and impacted files
@@              Coverage Diff               @@
##             2201.8.x   #41647      +/-   ##
==============================================
+ Coverage       76.34%   76.36%   +0.01%     
- Complexity      52518    52537      +19     
==============================================
  Files            2881     2880       -1     
  Lines          198587   198669      +82     
  Branches        25802    25810       +8     
==============================================
+ Hits           151615   151706      +91     
+ Misses          38614    38612       -2     
+ Partials         8358     8351       -7     
Files Coverage Δ
.../ballerina/runtime/internal/values/ErrorValue.java 84.09% <100.00%> (ø)
...lerina/runtime/internal/values/TableValueImpl.java 82.51% <100.00%> (+0.41%) ⬆️
.../java/io/ballerina/projects/JBallerinaBackend.java 77.56% <100.00%> (ø)
...erinalang/compiler/bir/codegen/JvmCodeGenUtil.java 93.33% <100.00%> (+0.03%) ⬆️
...llerinalang/compiler/bir/codegen/JvmConstants.java 100.00% <ø> (ø)
...nalang/compiler/bir/codegen/JvmInstructionGen.java 90.39% <100.00%> (ø)
...lerinalang/compiler/bir/codegen/JvmPackageGen.java 89.16% <100.00%> (ø)
...inalang/compiler/bir/codegen/JvmTerminatorGen.java 85.05% <ø> (ø)
...allerinalang/compiler/bir/codegen/JvmValueGen.java 96.21% <100.00%> (+3.11%) ⬆️
...lang/compiler/bir/codegen/ShutDownListenerGen.java 100.00% <100.00%> (ø)
... and 23 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@warunalakshitha warunalakshitha added this to the 2201.8.3 milestone Nov 6, 2023
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 635a77d into ballerina-platform:2201.8.x Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants