Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move object method bodies into a separate class when original class is too large #41398

Conversation

Nadeeshan96
Copy link
Contributor

@Nadeeshan96 Nadeeshan96 commented Sep 18, 2023

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Fixes #41279

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Nadeeshan96 Nadeeshan96 added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage: 92.94% and no project coverage change.

Comparison is base (cf7b31a) 76.33% compared to head (47b217b) 76.34%.
Report is 1 commits behind head on master.

❗ Current head 47b217b differs from pull request most recent head 8f2d66f. Consider uploading reports for the commit 8f2d66f to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #41398   +/-   ##
=========================================
  Coverage     76.33%   76.34%           
- Complexity    52484    52495   +11     
=========================================
  Files          2881     2881           
  Lines        198455   198519   +64     
  Branches      25799    25809   +10     
=========================================
+ Hits         151498   151554   +56     
- Misses        38598    38601    +3     
- Partials       8359     8364    +5     
Files Changed Coverage Δ
...llerinalang/compiler/bir/codegen/JvmConstants.java 100.00% <ø> (ø)
...lerinalang/compiler/bir/codegen/JvmPackageGen.java 89.16% <ø> (ø)
...inalang/compiler/bir/codegen/JvmTerminatorGen.java 85.05% <ø> (ø)
...ompiler/bir/codegen/interop/ExternalMethodGen.java 34.44% <ø> (ø)
...lang/compiler/bir/codegen/methodgen/MethodGen.java 95.89% <90.00%> (-0.44%) ⬇️
...allerinalang/compiler/bir/codegen/JvmValueGen.java 93.21% <95.00%> (+0.10%) ⬆️
.../ballerina/runtime/internal/values/ErrorValue.java 84.09% <100.00%> (ø)
...erinalang/compiler/bir/codegen/JvmCodeGenUtil.java 93.33% <100.00%> (+0.03%) ⬆️
...nalang/compiler/bir/codegen/JvmInstructionGen.java 90.39% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nadeeshan96
Copy link
Contributor Author

Closing this PR since we will merge the PR sent from ballerina-platform/ballerina-lang branch: #41409.

@Nadeeshan96 Nadeeshan96 deleted the master-file-too-large-41279 branch October 26, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: File too large error when building ballerina project
1 participant