next/739/20250219/v1 #12631
next/739/20250219/v1 #12631
Conversation
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
make clang-tidy happy even if unneeded for the temporary workaround
Will alow to have decode_frames accept one additional parameter with past fragment data
cf rfc9000 section 19.3. ACK Frames Ticket: 7556
Ticket: 7556 To do so, we need to add 2 buffers (one for each direction) to the QuicState structure, so that on parsing the second packet with hello/crypto fragment, we still have the data of the first hello/crypto fragment. Use a hardcoded limit so that these buffers cannot grow indefinitely and set an event when reaching the limit
Ticket: 7556
Ticket: 7556 Avoids failed_decrypt events when the first packet seen is not a Quic Initial packet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12631 +/- ##
==========================================
- Coverage 80.77% 80.76% -0.02%
==========================================
Files 932 932
Lines 259286 259381 +95
==========================================
+ Hits 209437 209484 +47
- Misses 49849 49897 +48
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 24803 |
QA never finished running on the staged PR. Are these stats deviations expected? #12617 ran w/o warnings |
I'd say yes, as the whole point of this effort was to get rid of parsing errors on valid traffic. It might be good to get pcaps from TLPW1 to confirm, but I'd like to get this merged in the meantime. We can do further refinement incrementally if necessary. |
|
@ct0br0 can you extract those pcaps and share them with @catenacyber ? Additionally, can you prep the baseline update? Thanks! |
Staging:
SV_BRANCH=OISF/suricata-verify#2309