Quic crypto reassembly 7556 v7 #12626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will alow to have decode_frames accept one additional parameter with past fragment data
cf rfc9000 section 19.3. ACK Frames Ticket: 7556
Ticket: 7556 To do so, we need to add 2 buffers (one for each direction) to the QuicState structure, so that on parsing the second packet with hello/crypto fragment, we still have the data of the first hello/crypto fragment. Use a hardcoded limit so that these buffers cannot grow indefinitely and set an event when reaching the limit
Ticket: 7556
Ticket: 7556 Avoids failed_decrypt events when the first packet seen is not a Quic Initial packet
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12626 +/- ##
==========================================
+ Coverage 80.74% 80.76% +0.01%
==========================================
Files 931 931
Lines 259144 259224 +80
==========================================
+ Hits 209242 209352 +110
+ Misses 49902 49872 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
victorjulien
approved these changes
Feb 19, 2025
Merged
|
Passed my QA. Ran this PR with SV PR OISF/suricata-verify#2307. Local pipeline 5256, run 735. |
|
🤞 |
|
WARNING:
Pipeline 24812 |
|
Merged in #12631, thanks! |
|
Great work, thanks @catenacyber. I think there are still some more fixes to be done, see the last pcap I added to the ticket. |
This was referenced Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7556
Describe changes:
SV_BRANCH=OISF/suricata-verify#2307
#12617 with