Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libhtp rs v27.5 #12616

Closed
wants to merge 5 commits into from
Closed

Libhtp rs v27.5 #12616

wants to merge 5 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/2696

Describe changes:

  • prepare libhtp-rs by minimizing the diff for src subdir

This allow to go one small step further

#12509 next round now focusing on src/app-layer-htp.c

#12600 with added commit for macro hygiene

In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
In preparation of libhtp rust
make clang-tidy happy even if unneeded for the temporary workaround
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 96.10390% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.75%. Comparing base (10ede91) to head (989e73d).
Report is 30 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12616   +/-   ##
=======================================
  Coverage   80.74%   80.75%           
=======================================
  Files         931      931           
  Lines      259144   259159   +15     
=======================================
+ Hits       209242   209277   +35     
+ Misses      49902    49882   -20     
Flag Coverage Δ
fuzzcorpus 56.97% <86.75%> (+<0.01%) ⬆️
livemode 19.38% <9.27%> (-0.01%) ⬇️
pcap 44.18% <85.43%> (+0.03%) ⬆️
suricata-verify 63.43% <89.40%> (-0.01%) ⬇️
unittests 58.34% <83.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24776

@victorjulien victorjulien added this to the 8.0 milestone Feb 19, 2025
@catenacyber catenacyber mentioned this pull request Feb 19, 2025
@victorjulien
Copy link
Member

Merged in #12631, thanks!

@catenacyber
Copy link
Contributor Author

I think this was the last PR of its kind...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants