Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v4.0-branch] drivers: led: lp50xx: check the number of LED colors #85912

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Feb 18, 2025

Backport ffbb8f9 from #85607.
Fixes #86101.

The current code assumes (especially in the lp50xx_set_color function)
that the number of LED colors defined in DT is not greater than 3. But
since this is not checked, then this is not necessarily the case...

This patch consolidates the initialization of the lp50xx LED driver by
checking the number of colors for each LED found in DT.

Signed-off-by: Simon Guinot <simon.guinot@sequanux.org>
(cherry picked from commit ffbb8f9)
@zephyrbot zephyrbot added Backport Backport PR and backport failure issues area: LED Label to identify LED subsystem labels Feb 18, 2025
@henrikbrixandersen
Copy link
Member

This needs a bug report in order to get backported.

@ivanwagner
Copy link

The bug report is #85607

@henrikbrixandersen
Copy link
Member

The bug report is #85607

No, that's the pull request against the main branch. For backports, a bug issue is required.

@ivanwagner
Copy link

Sure... This is the bug report #86101

Copy link
Collaborator

@simonguinot simonguinot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I am off this week.

@fabiobaltieri fabiobaltieri added this to the v4.0.1 milestone Feb 26, 2025
@mmahadevan108 mmahadevan108 merged commit af81a8b into v4.0-branch Feb 26, 2025
29 of 31 checks passed
@mmahadevan108 mmahadevan108 deleted the backport-85607-to-v4.0-branch branch February 26, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: LED Label to identify LED subsystem Backport Backport PR and backport failure issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants