Zarr v3: support root path #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3 spec states path = '/' for arrays gives /meta/root.array.json
path = '/' for groups gives /meta/root.array.json
In this implementation path = None or path = '' will also result in
a root array. Creation routines default to path=None, so this makes
it so that the path argument does not have to be manually specified.
update additional tests
update test_nbytes_stored to handle both v3 and v2 cases properly
previous behavior corresponded to at_root=True by default
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 34 34
Lines 13846 13853 +7
=======================================
+ Hits 13839 13846 +7
Misses 7 7
|
|
@grlee77, thanks for this! Reading over it, it does seem to address the issues that Stephan raised. Do you have anything else for this PR from your side or just need testing and then rolling into a 2.12.x release?? |
|
I think test coverage is pretty good now. It should be ready for review. |
|
Rolling into a 2.13 pre-release for better testing together with xarray. cc: @shoyer |
grlee77
added a commit
to grlee77/zarr-python
that referenced
this pull request
Sep 21, 2022
path=None support was previously added in zarr-developersgh-1085. This change should have been made at that time.
6 tasks
joshmoore
pushed a commit
that referenced
this pull request
Sep 22, 2022
path=None support was previously added in gh-1085. This change should have been made at that time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1039
v3 spec states path = '/' for arrays gives an array at /meta/root.array.json
path = '/' for groups gives a group at /meta/root.array.json
In this implementation
path=Nonewill also result in a root array. Creation routines default topath=None, so this makes it so that the path argument does not have to be manually specified.TODO: