Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow empty path in open_consolidated for zarr v3 #1142

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Sep 21, 2022

closes #1141

path=None support for v3 was previously added in gh-1085. This change should have also been made at that time.

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

path=None support was previously added in zarr-developersgh-1085. This change should have
been made at that time.
@grlee77 grlee77 added the bug Potential issues with the zarr-python library label Sep 21, 2022
@grlee77 grlee77 changed the title allow empty path in open_consolidated for zarr v3 as well allow empty path in open_consolidated for zarr v3 Sep 21, 2022
@joshmoore
Copy link
Member

Thanks, @grlee77. Looking at pydata/xarray#6475, I'm going to merge and move ahead with 2.13.0.

@joshmoore joshmoore merged commit 718ee13 into zarr-developers:main Sep 22, 2022
joshmoore added a commit to joshmoore/zarr-python that referenced this pull request Sep 22, 2022
joshmoore added a commit that referenced this pull request Sep 22, 2022
* Prepare 2.13.0 release

* Update release instructions for pre-releases

* Add #1142 for Greg's work

* Make python-version match for pre-commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Potential issues with the zarr-python library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zarr v3 arrays with consolidated metadata still require path
2 participants