Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests by recreating the repo every time #417

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

abarciauskas-bgse
Copy link
Collaborator

@abarciauskas-bgse abarciauskas-bgse commented Feb 3, 2025

I believe the issue here was that the repo was not getting torn down after each test, and using a fixture with the @pytest.fixture(scope="function") for the repo seems to fix the issue.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (24a4582) to head (0ec1ae3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #417   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files          31       31           
  Lines        1839     1839           
=======================================
  Hits         1545     1545           
  Misses        294      294           

Copy link
Member

@TomNicholas TomNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!!

@mpiannucci you can tell us if there was a better way of doing this later :)

For now let's merge because this makes everything green!!!

@TomNicholas
Copy link
Member

Actually just before merging @abarciauskas-bgse can you add/change release notes to note that we actually support icechunk a12 now not a8? Then please merge

@TomNicholas TomNicholas added the Icechunk 🧊 Relates to Icechunk library / spec label Feb 3, 2025
@abarciauskas-bgse abarciauskas-bgse merged commit 326440b into main Feb 4, 2025
12 checks passed
@TomNicholas TomNicholas deleted the fix/repository-must-be-clean branch February 4, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Icechunk 🧊 Relates to Icechunk library / spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix append failures in upstream tests
2 participants