-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests by recreating the repo every time #417
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage 84.01% 84.01%
=======================================
Files 31 31
Lines 1839 1839
=======================================
Hits 1545 1545
Misses 294 294 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!!
@mpiannucci you can tell us if there was a better way of doing this later :)
For now let's merge because this makes everything green!!!
Actually just before merging @abarciauskas-bgse can you add/change release notes to note that we actually support icechunk a12 now not a8? Then please merge |
…pers/virtualizarr into fix/repository-must-be-clean
I believe the issue here was that the repo was not getting torn down after each test, and using a fixture with the
@pytest.fixture(scope="function")
for the repo seems to fix the issue.