-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The examples of the docs raise IcechunkError: repository error: repositories can only be created in clean prefixes #665
Comments
Thank for reporting this @josephnowak . I'm not able to reproduce this locally, which makes me thing this is probably a bug for Windows users. We still don't have a good test suite for Windows. We'll ship a fix on Monday. |
In the meantime, could you try creating your repo in a nonexistent directory?
|
Thanks for the fast response. I ran the same code on Linux (same machine) and it did not raise the error as you mentioned. I tried to run the code with the "some-dir-that-doesnt-exist" and it raised the same error on Windows, but I can test directly on Linux thanks. |
Thank you @josephnowak , that's valuable input. We'll fix this and get back to you. |
I'm seeing this error in VirtualiZarr CI, which is on linux e.g. here |
But our test fixtures might be guilty of this (cc @mpiannucci ) |
@TomNicholas @paraseba thanks for the hint, it was indeed that the test fixtures for the append feature were not using a repo fixture, so the repo object was not being torn down after every test (fixed in zarr-developers/VirtualiZarr#417). I'm not entirely sure why it would matter since the tmp_path of the storage config should have been different for each of these tests, so if anyone can enlighten me on that I would appreciate it. |
@josephnowak I tried to fix the local file Storage instance in Windows, here is my initial attempt, but I failed. It's a bit tricky, for me particularly, I have very little windows experience, and from more than 20 years ago. The issue seems to be something simple around paths, it cannot form an absolute path from the temporary directory we are giving it. I printed the directory and it looks reasonable, so I'm not sure. I suspect Icechunk will work in windows, outside of the local file storage. Have you tried hitting s3 or in memory storage? Any chance you could pick up my attempt at fixing this? I can help with any Icechunk stuff you may need. |
Thanks for dedicating time to fix this, and sure, I will take a look in a couple of days at that branch to try to see if I can find the problem. I already tested using S3 with standard buckets on Windows and at least I was able to create the repository, I will do some additional tests later to see if I can write some datasets. |
Sounds great @josephnowak, thank you! Glad to hear you made it work against S3 from Windows. |
Hi,
I'm very excited to start using Icechunk, and I saw that you released the first non-alpha version, I thought to test it for the first time, but I have found that some of the examples fail with the error that the title mentions (IcechunkError: repository error: repositories can only be created in clean prefixes), I would like to know if I'm doing something wrong, but I'm mostly copying and pasting the code of the example. (I understand that is normal to have such errors in a product that is so recent but I thought that it would be good to report it, if you already know about them you can close this issue)
I also tried to do it with a non temporal folder and I got the same error.
Traceback:
Additionally, I have noticed that some of the examples have some small details with the names of the variables, like this one:
The storage_config variable was never created which makes it unusable if you copy and paste it directly.
Additional information about my environment:
INSTALLED VERSIONS
commit: None
python: 3.12.8 | packaged by conda-forge | (main, Dec 5 2024, 14:06:27) [MSC v.1942 64 bit (AMD64)]
python-bits: 64
OS: Windows
OS-release: 11
machine: AMD64
processor: Intel64 Family 6 Model 165 Stepping 2, GenuineIntel
byteorder: little
LC_ALL: None
LANG: None
LOCALE: ('Spanish_Venezuela', '1252')
libhdf5: None
libnetcdf: None
xarray: 2025.1.2
pandas: 2.2.3
numpy: 2.2.2
scipy: None
netCDF4: None
pydap: None
h5netcdf: None
h5py: None
zarr: 3.0.2
cftime: None
nc_time_axis: None
iris: None
bottleneck: None
dask: 2025.1.0
distributed: None
matplotlib: None
cartopy: None
seaborn: None
numbagg: None
fsspec: 2025.2.0
cupy: None
pint: None
sparse: None
flox: None
numpy_groupies: None
setuptools: 75.8.0
pip: 25.0
conda: None
pytest: None
mypy: None
IPython: 8.32.0
sphinx: None
icechunk: 0.1.0
The text was updated successfully, but these errors were encountered: