[DB-14898] Adding validations for AssesmentIssues field of assessment report struct/json in the tests #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -893,7 +893,6 @@ normalize_json() { | |||
| .OptimalInsertConnectionsPerNode? = "IGNORED" | | |||
| .RowCount? = "IGNORED" | | |||
| .FeatureDescription? = "IGNORED" | # Ignore FeatureDescription instead of fixing it in all tests since it will be removed soon | |||
| .AssessmentIssues? = "IGNORED" | # Ignore AssessmentIssues until all tests are updated | |||
There was a problem hiding this comment.
PR title says cleanup of report struct but I don't see any code changes. Is that not included in this PR?
There was a problem hiding this comment.
Updated PR desc and jira ticket also
sanyamsinghal
changed the title
There was a problem hiding this comment.
There are two more schemas mgi and rna which are not in GH but in jenkins, I believe the expected files of those need to be updated as well
There was a problem hiding this comment.
oh ok is it under pg complex schemas? Rest of the PG tests in jenkins i ran and passed.
sanyamsinghal
force-pushed
the
sanyam/json-reports
branch
from
c72bac4 to
1ee2a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes in this pull request
https://yugabyte.atlassian.net/browse/DB-14898
Describe if there are any user-facing changes
NA
How was this pull request tested?
Updated all tests to include the new field and validate its value.
So passing of all PG and oracle tests can ensure this.
Does your PR have changes that can cause upgrade issues?