[DB-14898] Adding validations for AssesmentIssues field of assessment…

… report struct/json in the tests (#2275) * Updated all tests to verify/validate the AssessmentIssues array in report by adding expected values for it
yugabyte · Feb 3, 2025 · 9a30ec6 · 9a30ec6
1 parent 72ccbd1
commit 9a30ec6
Show file tree

Hide file tree

Showing 15 changed files with 8,231 additions and 1 deletion.
diff --git a/migtests/scripts/functions.sh b/migtests/scripts/functions.sh
@@ -893,7 +893,6 @@ normalize_json() {
             .OptimalInsertConnectionsPerNode? = "IGNORED" |
             .RowCount? = "IGNORED" |
 			.FeatureDescription? = "IGNORED" | # Ignore FeatureDescription instead of fixing it in all tests since it will be removed soon
-			.AssessmentIssues? = "IGNORED" | # Ignore AssessmentIssues until all tests are updated
             # Replace newline characters in SqlStatement with spaces
 			.SqlStatement? |= (
 				if type == "string" then

diff --git a/migtests/tests/oracle/assessment-report-test/expectedAssessmentReport.json b/migtests/tests/oracle/assessment-report-test/expectedAssessmentReport.json
@@ -262,6 +262,229 @@
 		}
 	],
 	"UnsupportedFeaturesDesc": "Features of the source database that are not supported on the target YugabyteDB.",
+	"AssessmentIssues": [
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "COMPOUND_TRIGGER",
+			"Name": "",
+			"Description": "COMPOUND TRIGGER not supported in YugabyteDB. ",
+			"Impact": "-",
+			"ObjectType": "TRIGGER",
+			"ObjectName": "trg_simple_insert",
+			"SqlStatement": "CREATE TRIGGER trg_simple_insert\n\tCOMPOUND INSERT ON simple_table FOR EACH ROW\n\tEXECUTE PROCEDURE trigger_fct_trg_simple_insert();",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "UNSUPPORTED_INDEXES",
+			"Name": "Unsupported Indexes",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "INDEX",
+			"ObjectName": "Index Name: TEXT_INDEX, Index Type=DOMAIN INDEX",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "UNSUPPORTED_INDEXES",
+			"Name": "Unsupported Indexes",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "INDEX",
+			"ObjectName": "Index Name: IDX_EMP_DEPT_CLUSTER, Index Type=CLUSTER INDEX",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "UNSUPPORTED_INDEXES",
+			"Name": "Unsupported Indexes",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "INDEX",
+			"ObjectName": "Index Name: REV_INDEX, Index Type=NORMAL/REV INDEX",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "UNSUPPORTED_INDEXES",
+			"Name": "Unsupported Indexes",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "INDEX",
+			"ObjectName": "Index Name: FUNC_REV_INDEX, Index Type=FUNCTION-BASED NORMAL/REV INDEX",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "UNSUPPORTED_INDEXES",
+			"Name": "Unsupported Indexes",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "INDEX",
+			"ObjectName": "Index Name: PK_IOT_TABLE, Index Type=IOT - TOP INDEX",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "INHERITED_TYPES",
+			"Name": "Inherited Types",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "TYPE",
+			"ObjectName": "SIMPLE_CAR_TYPE",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "VIRTUAL_COLUMNS",
+			"Name": "Virtual Columns",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "COLUMN",
+			"ObjectName": "GENERATED_COLUMN_TABLE.TOTAL_PRICE",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "VIRTUAL_COLUMNS",
+			"Name": "Virtual Columns",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "COLUMN",
+			"ObjectName": "XML_TABLE.DATA",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "UNSUPPORTED_PARTITIONING_METHODS",
+			"Name": "Unsupported Partitioning Methods",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "TABLE",
+			"ObjectName": "Table Name: EMPLOYEES2, Partition Method: REFERENCE PARTITION",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_features",
+			"CategoryDescription": "Features of the source database that are not supported on the target YugabyteDB.",
+			"Type": "UNSUPPORTED_PARTITIONING_METHODS",
+			"Name": "Unsupported Partitioning Methods",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "TABLE",
+			"ObjectName": "Table Name: SALES, Partition Method: SYSTEM PARTITION",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_datatypes",
+			"CategoryDescription": "Data types of the source database that are not supported on the target YugabyteDB.",
+			"Type": "XMLTYPE",
+			"Name": "XMLTYPE",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "COLUMN",
+			"ObjectName": "TEST_SCHEMA.XML_TABLE.DATA",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_datatypes",
+			"CategoryDescription": "Data types of the source database that are not supported on the target YugabyteDB.",
+			"Type": "BFILE",
+			"Name": "BFILE",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "COLUMN",
+			"ObjectName": "TEST_SCHEMA.BFILE_TABLE.DATA",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_datatypes",
+			"CategoryDescription": "Data types of the source database that are not supported on the target YugabyteDB.",
+			"Type": "NCLOB",
+			"Name": "NCLOB",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "COLUMN",
+			"ObjectName": "TEST_SCHEMA.NCLOB_TABLE.DATA",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_datatypes",
+			"CategoryDescription": "Data types of the source database that are not supported on the target YugabyteDB.",
+			"Type": "CLOB",
+			"Name": "CLOB",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "COLUMN",
+			"ObjectName": "TEST_SCHEMA.CLOB_TABLE.DATA",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_datatypes",
+			"CategoryDescription": "Data types of the source database that are not supported on the target YugabyteDB.",
+			"Type": "BLOB",
+			"Name": "BLOB",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "COLUMN",
+			"ObjectName": "TEST_SCHEMA.BLOB_TABLE.DATA",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		},
+		{
+			"Category": "unsupported_datatypes",
+			"CategoryDescription": "Data types of the source database that are not supported on the target YugabyteDB.",
+			"Type": "CLOB",
+			"Name": "CLOB",
+			"Description": "",
+			"Impact": "-",
+			"ObjectType": "COLUMN",
+			"ObjectName": "TEST_SCHEMA.TEXT_TABLE.TEXT_DATA",
+			"SqlStatement": "",
+			"DocsLink": "",
+			"MinimumVersionsFixedIn": null
+		}
+	],
 	"TableIndexStats": [
 		{
 			"SchemaName": "TEST_SCHEMA",