Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substance Designer: Refactoring Textures Product Type #11

Merged
merged 12 commits into from
Feb 11, 2025

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Feb 5, 2025

Changelog Description

General refactoring and enhancing Textures Product Type:

  • Sync the settings of image format and review with server settings.
    image

  • Supports to export selected graphs and selected output nodes
    image

Resolve # #5, #7, #10, #6, #9,

Additional review information

Need to test along with core addon ynput/ayon-core#1129

  • If you want to publish the instances, you still need to load one of the graphs.
  • Colorspace data is somehow hardcoded according to the default exported colorspace data
    image

Testing notes:

  1. Launch Substance Designer
  2. Create Texture
  3. Play around with the new settings.

@moonyuet moonyuet requested a review from LiborBatek February 6, 2025 13:31
@moonyuet moonyuet added the sponsored This is directly sponsored by a client or community member label Feb 6, 2025
@moonyuet moonyuet marked this pull request as ready for review February 6, 2025 14:24
@moonyuet moonyuet requested a review from BigRoy February 6, 2025 14:24
@LiborBatek
Copy link
Member

I have tested the new options in the publisher and I was able to produce publishes of multiple packages and also selectively of color outputs which is good!

Im just curious about the product name is there a way to tweak it via template? as I couldnt manage it.

as now the formatting changed to following one:
Screenshot 2025-02-06 174252

note: I dont know if SDesigner been using Color Management as from the publish logs it seems images doesnt have any colorspace data and been skipped by OIIO transcode when trying to transcode for thumbnails... is it something still missing atm?

@moonyuet
Copy link
Member Author

moonyuet commented Feb 7, 2025

Im just curious about the product name is there a way to tweak it via template? as I couldnt manage it.

You need to manage the name via ayon+settings://core/tools/creator/product_name_profiles in the server setting
image

note: I dont know if SDesigner been using Color Management as from the publish logs it seems images doesnt have any colorspace data and been skipped by OIIO transcode when trying to transcode for thumbnails... is it something still missing atm?

Currently there is some api limitation to accurately get the colorspace data, so we need to somehow get the data with the hardcoded data. (Taking reference from the default output colorspace and use it as the colorspace data, f5b02d2 did this)
We need to probably ask Adobe to see if there is better way to get the colorspace data.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made multiple tests and it looks good to me...

I guess good to go?

@moonyuet moonyuet merged commit b9bd688 into develop Feb 11, 2025
2 checks passed
@moonyuet moonyuet deleted the enhancement/substance_designer_refactoring branch February 11, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
2 participants