Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom product name profiles for substance designer #1129

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Feb 6, 2025

Changelog Description

Add custom product name profiles for substance designer
Fix ynput/ayon-substance-designer#9

Additional info

Test with ynput/ayon-substance-designer#11

Testing notes:

  1. Launch Substance Designer
  2. Create Texture
  3. Play around with the new settings.

@moonyuet moonyuet added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Feb 6, 2025
@moonyuet moonyuet requested a review from LiborBatek February 6, 2025 14:23
@moonyuet moonyuet self-assigned this Feb 6, 2025
@ynbot ynbot added the size/XS label Feb 6, 2025
Comment on lines +487 to +497
},
{
"product_types": [
"textureSet"
],
"hosts": [
"substancedesigner"
],
"task_types": [],
"tasks": [],
"template": "T_{folder[name]}{variant}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels overly specific to unreal - and I have my doubts about whether this is a sensible default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this here, and if the users want to add the template, we can suggest them to add the parameter accordingly to this.

server/settings/tools.py Outdated Show resolved Hide resolved
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
...merging I guess depends more on the devs pov atm

@moonyuet moonyuet merged commit 48d94b6 into develop Feb 11, 2025
7 checks passed
@moonyuet moonyuet deleted the enhancement/Add-ability-to-have-folder-name]-as-a-valid-key-for-publish-instance-name branch February 11, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add ability to have folder[name] as a valid key for publish instance name
4 participants