CI: Use misspell binary #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building misspell might use lots of resource and be killed. #513 (comment) ref: https://github.com/client9/misspell#install
rhysd
suggested changes
Jul 5, 2017
.drone.yml
Outdated
| @@ -8,7 +8,7 @@ build: | |||
| - REVIEWDOG_GITHUB_API_TOKEN=$$REVIEWDOG_GITHUB_API_TOKEN | |||
| commands: | |||
| - go get -d -v ./scripts | |||
| - go get -u github.com/client9/misspell/cmd/misspell | |||
| - curl -L https://git.io/misspell | sh | |||
There was a problem hiding this comment.
From misspell's installation document,
Both will install as ./bin/misspell.
So we might need to specify misspell executable with relative path in reviewdog.yml or specify a directory to install with -b option.
There was a problem hiding this comment.
Oops, thank you for the catch!
vim-jp-bot
reviewed
Jul 5, 2017
autoload/vital.vim
Outdated
| @@ -10,3 +10,5 @@ function! vital#of(name) abort | |||
| endif | |||
| return vital#_{substitute(ver[0], '\W', '', 'g')}#new() | |||
| endfunction | |||
|
|
|||
| let g:exsiting_variable = 1 | |||
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"exsiting" is a misspelling of "existing"
vim-jp-bot
reviewed
Jul 5, 2017
autoload/vital.vim
Outdated
| @@ -10,3 +10,5 @@ function! vital#of(name) abort | |||
| endif | |||
| return vital#_{substitute(ver[0], '\W', '', 'g')}#new() | |||
| endfunction | |||
|
|
|||
| let g:exsiting_variable = 1 | |||
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"exsiting" is a misspelling of "existing"
|
Fixed. Please take another look. |
vim-jp-bot
reviewed
Jul 5, 2017
autoload/vital.vim
Outdated
| @@ -10,3 +10,5 @@ function! vital#of(name) abort | |||
| endif | |||
| return vital#_{substitute(ver[0], '\W', '', 'g')}#new() | |||
| endfunction | |||
|
|
|||
| let g:exsiting_variable = 1 | |||
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"exsiting" is a misspelling of "existing"
rhysd
approved these changes
Jul 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building misspell might use lots of resource and be killed.
#513 (comment)
ref: https://github.com/client9/misspell#install