Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use misspell binary #529

Merged
merged 2 commits into from
Jul 5, 2017
Merged

CI: Use misspell binary #529

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ee12f4
CI: Use misspell binary
haya14busa Jul 5, 2017
f6422d9
CI: specify installation directory
haya14busa Jul 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .drone.sec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
eyJhbGciOiJSU0EtT0FFUCIsImVuYyI6IkExMjhHQ00ifQ.y-ncpKyfad3NOIgDws6b5ESZytbQ2SBJSHYsVgCsc14aj_BtmhxXgTsDWrBntn1C7XGJD9fEAXaq_jie8xq5cHlglq6rxhO9L34QKJvJlafYF3SKG5XuwlJfYd2yb44n8XQdymJisv7J0RQaPLj_XsrjbCM1d6MbN6jO1SafG8GHTDiDcF9tkh_LDifaU_0bu15_hJdoW3UM3e0VAopEMaoxPwOKGv-ncmWpcn8AwJQ7PR7g_LvIWT6eg5p3XzMagN7iIovWdr_IKP83iCSamU6h_9RGtS-agDBDiTLqAr9ahdUSudgvop4ge0GdMKqWN816eOlgPBTSGsFT7I3axQ.WDqI7Fmcym8l3CTk.hGe6qvX1ChJ-TCI1X7CB7XIqMwbE5I_avgmqeoAiltg3J6zD3tLmu3ExR_IPKalbWbTyHyw27TijSHe94zzowyklGYS994fjnBVukvtry4FTo8iAL0K5Dy_TBHCzAMDcaJOiAmUkctsRE9Vc65lW0zw8B0KAbrTH2G-TyV-6w_Ys-UE03avBT55JgLs2Dvrv7FrDSDn9UATAEjSVgVl3.-TKphKpveKxh2ShPP4AyYw
eyJhbGciOiJSU0EtT0FFUCIsImVuYyI6IkExMjhHQ00ifQ.WwqqcFE9o8QJO0HOXJW8EKgQzcFKJNunNjhCZKzAhLx1NDAIry0TyLIKsycphCS3X2yPrM5ClmhC7iBfoMSa6RLySnMLcpi9s-S1yCKbKWgeAf1Ppii1QRvvDo76MQyfTCyHT84W3NbYIhaOMdAnqiwfG6UxbKhP1oDt5Kaud8T-fkurUwd5fiTWL5-d7Z9_riKIS8BpdppMLJh8ixL8KbB9DQ4kmVUDAKudnv7uOC4ljPA0mbrTtmzmK8yMoTHikW6ytboTWtPqnUXgYi4hpUKEFnQSSywChM_Kcjg_eNirVfWLGaOEyO8g2yCx0LspExifAcPNyQlXqZ3hmNLLTQ.7JRjrBC1OzFCnpSM.5NYWALDygJRanmPZ4Q8YL0ikCA6Vkk94RvgrF9jYIPAldqUhKTVCCU_CHsxPYDNxz-tgIc4-r6ICiqNmKXBZxuChgF6GJHbg18fplnxWFjF2IWtVUlHjengvtNWj2YmmsG1Smd_I_iUsWeDhTvwLp5hAOgfsjw2oIxsATfcQG-DK34CJYnxRqhy2GJmhMCeYDCUeY65RjMAmajx3LwmH.ao3tfv_P9VsyClZubovCeA
2 changes: 1 addition & 1 deletion .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ build:
- REVIEWDOG_GITHUB_API_TOKEN=$$REVIEWDOG_GITHUB_API_TOKEN
commands:
- go get -d -v ./scripts
- go get -u github.com/client9/misspell/cmd/misspell
- curl -L https://git.io/misspell | sh
Copy link
Contributor

@rhysd rhysd Jul 5, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From misspell's installation document,

Both will install as ./bin/misspell.

So we might need to specify misspell executable with relative path in reviewdog.yml or specify a directory to install with -b option.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you for the catch!

- reviewdog -ci=droneio
when:
event: pull_request