Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exit handling for GBWT buffer size in autoindex #4184

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

jeizenga
Copy link
Contributor

@jeizenga jeizenga commented Dec 7, 2023

Changelog Entry

To be copied to the draft changelog by merger:

  • vg autoindex won't enter infinite loop when there is not enough disk space to write a GBWT

Description

Probably resolves #4183.

GBWT no longer exits when has insufficient buffer size, so there is no longer a reason to handle exit codes on the autoindex size. Also, the existing exit handling doesn't differentiate between different codes, so there is a risk that it can thrash when encountering exits for another reason, such as insufficient disk space.

@jeizenga jeizenga merged commit 3566725 into master Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stuck in the autoindex command around three days
2 participants