Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove end date #208

Merged
merged 34 commits into from
Feb 10, 2024
Merged

Remove end date #208

merged 34 commits into from
Feb 10, 2024

Conversation

tommyneu
Copy link
Member

@tommyneu tommyneu commented Jan 2, 2024

The current way data is being created and stored has led to some sorting issues where ongoing events are being sorted before any other events in a list of events.

The best solution we have come up with to resolve the issues is to remove the end date and force on going events to be daily recurring instead. This would mean no single event occurrence would last more than 24 hour.

This also lets us update the time input fields and add a new column for time modes where more information about the timings of the event occurrence can be stored.

@tommyneu
Copy link
Member Author

SQL conversion script was tested and confirmed working on events-dev.unl.edu with the version of mariaDB running on the server

@tommyneu tommyneu marked this pull request as ready for review February 5, 2024 16:35
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

41.4% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

This was linked to issues Feb 6, 2024
@tommyneu tommyneu merged commit 90c087e into unl:master Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change event order Time TBD
1 participant