Add the tool/externaltaskmonitor plugin to Moodle 4.4 #54
Conversation
…rnaltaskmonitor as a submodule from its MOODLE_404_STABLE branch.
* Enable submodules checkout in GHA. * Add token variable for checking out private repos in GHA. * Disable PostgreSQL tests in GHA.
ctam
force-pushed
the
UCSFCLE_404-Issue#52-Add_tool_externaltaskmonitor_plugin_to_Moodle_4.4
branch
from
426202d to
dd173c2
Compare
|
why not just delete unwanted lines in push.yml instead of commenting them out? |
|
Good question. I do want to preserve the general structure of the original file from Moodle HQ and also be able to insert my comments regarding why we want to disable Grunt in the submodules and PostgreSQL testing in the file. My concern is that a developer would come in and start adding new changes to the file without knowing that all these cool features have already been implemented in Moodle HQ's repo. As time goes on, this file may become unrecognizable that we start adding new changes and make it further deviate from the Moodle HQ's code. I didn't think it's practical for a developer to always check the commit log before coding for a feature. In this case say, adding support for PostgreSQL. If there is a better way to ensure that, I am all ears. |
|
Thanks for your comment. I think I will leave them there for now. I really don't want to see a developer start coding his own way of setting up, say, a different PostgreSQL image while they could've simply used |
ctam
deleted the
UCSFCLE_404-Issue#52-Add_tool_externaltaskmonitor_plugin_to_Moodle_4.4
branch
This PR includes changes to
push.ymlthat enable GHA in submodules.