Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds tool_ilioscategoryassignment plugin. #49

Closed
wants to merge 2 commits into from
Closed

adds tool_ilioscategoryassignment plugin. #49

wants to merge 2 commits into from

Conversation

stopfstedt
Copy link
Member

No description provided.

@stopfstedt stopfstedt force-pushed the moodle4.4_upgrade_add_tool_ilioscategoryassignment branch 3 times, most recently from 2fa6afc to a384972 Compare August 30, 2024 20:30
@ctam
Copy link

ctam commented Sep 6, 2024

@stopfstedt, we added code to checkout submodules in GHA in #54. You may want to do a git rebase origin/UCSFCLE_404_STABLE and try your PR again.

@ctam ctam assigned ctam and stopfstedt and unassigned ctam Sep 6, 2024
@ctam ctam self-requested a review September 6, 2024 03:03
@ctam ctam linked an issue Sep 6, 2024 that may be closed by this pull request
Add ilios/tool_ilioscategoryassignment plugin to Moodle 4.4 #56
Closed
@stopfstedt stopfstedt force-pushed the moodle4.4_upgrade_add_tool_ilioscategoryassignment branch from a384972 to 23793e6 Compare September 6, 2024 21:28
@stopfstedt
Copy link
Member Author

@ctam - rebased 👍

i fixed indentation in the git modules file while at it.

@ctam
Copy link

ctam commented Sep 7, 2024

Error in GHA.

There was 1 failure:

1) core_privacy\privacy\provider_test::test_table_coverage
The following tables with user fields must be covered with metadata providers: 
  - tool_ilioscategoryassignment (usermodified)

/home/runner/work/moodle/moodle/privacy/tests/privacy/provider_test.php:328
/home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:72

FAILURES!

I will convert this PR to draft until it is ready.

@ctam ctam marked this pull request as draft September 7, 2024 01:00
@stopfstedt stopfstedt mentioned this pull request Sep 9, 2024
Closed
@stopfstedt
update to version 2024090900.
c8855d4 
this update brings in the reworked privacy provider for this plugin.
@ctam ctam requested a review from a team September 9, 2024 22:37
ctam
ctam reviewed Sep 10, 2024
View reviewed changes
Copy link

@ctam ctam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question on the .gitmodules file.

.gitmodules
path = admin/tool/externaltaskmonitor
url = https://github.com/ucsf-education/tool_externaltaskmonitor
branch = MOODLE_404_STABLE
path = admin/tool/externaltaskmonitor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @stopfstedt, does your git submodule add command insert spaces for indentation instead of tabs? Did you have to change any git configuration to do that? Mine is defaulted to insert tabs. Please lmk.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted back to tabs in #68

@ctam ctam marked this pull request as ready for review September 10, 2024 23:31
@stopfstedt stopfstedt mentioned this pull request Sep 17, 2024
Merged
@stopfstedt
Copy link
Member Author

this PR has been superseded by #68

@stopfstedt stopfstedt closed this Sep 17, 2024
@ctam ctam deleted the moodle4.4_upgrade_add_tool_ilioscategoryassignment branch September 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctam ctam ctam left review comments

Assignees

@stopfstedt stopfstedt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ilios/tool_ilioscategoryassignment plugin to Moodle 4.4
2 participants
@stopfstedt @ctam