-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update actions used in GitHub Actions workflows #990
Conversation
- Update the runner image to `ubuntu-24.04`. `ubuntu-20.04` is now deprecated: actions/runner-images#11101 - Update `actions/checkout` to v4. - Update `actions/setup-java` to v4 and set the distribution to `temurin`.
24.04 is fine.
We use temurin internally, this is fine. CI seems to be failing to resolve some maven deps with a module file. |
The failing dependencies are: rxpermissionsLooking on Maven Central, the only result appears to be a fork of that dependency: https://central.sonatype.com/artifact/io.github.mayampi01/com.tbruyelle.rxpermissions2. If it's ok for you, I can change the coordinate of the dependency to the one I linked above. xlog-android-idleFor this one, there doesn't seem to be any result on Maven Central: https://central.sonatype.com/search?q=xlog-android-idle. The dependency seems to be used only in the example app, so maybe it could be removed too? |
I assume both of these went down with jcenter. They both seem overkill for having in a sample app, and I don't see much/any usage. For rxPermissions, I see none, let's kill it. Xlog looks fine to delete too, but need the couple references stripped. Was used to support annotation based logging, I don't see any more uses of that in the app. @raviagarwal7 Do you have an idea about these old deps? |
Agreed, we can remove both the deps and cleanup usages if any. The deps are used in sample apps which can be simplified. |
Ok, I'll update the PR accordingly to remove these two dependencies. |
6b0359d
to
1030799
Compare
I've removed the two mentioned dependencies. I wasn't able to test locally if this works: after 30 min the build was still running. |
I've updated my PR to use Python 3.8 in the A couple of notes:
|
And now it works 🎉 |
Looks good, thanks for the follow-up and helping get this fixed! |
Description
ubuntu-24.04
.ubuntu-20.04
is now deprecated: The Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and will be fully unsupported by 2025-04-15 actions/runner-images#11101actions/checkout
to v4.actions/setup-java
to v4 and set the distribution totemurin
.Note
ubuntu-latest
instead ofubuntu-24.04
. Let me know which option you prefer.actions/setup-java
supports a wide range of distributions. Let me know if you'd prefer to use something else thantemurin
.