Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions used in GitHub Actions workflows #990

Merged
merged 4 commits into from
Feb 22, 2025

Conversation

MGaetan89
Copy link
Contributor

Description

Note

  • It's possible to use ubuntu-latest instead of ubuntu-24.04. Let me know which option you prefer.
  • actions/setup-java supports a wide range of distributions. Let me know if you'd prefer to use something else than temurin.

- Update the runner image to `ubuntu-24.04`. `ubuntu-20.04` is now deprecated: actions/runner-images#11101
- Update `actions/checkout` to v4.
- Update `actions/setup-java` to v4 and set the distribution to `temurin`.
@tyvsmith
Copy link
Member

tyvsmith commented Feb 19, 2025

It's possible to use ubuntu-latest instead of ubuntu-24.04. Let me know which option you prefer.

24.04 is fine.

actions/setup-java supports a wide range of distributions. Let me know if you'd prefer to use something else than temurin.

We use temurin internally, this is fine.

CI seems to be failing to resolve some maven deps with a module file.

@MGaetan89
Copy link
Contributor Author

The failing dependencies are: com.tbruyelle.rxpermissions2:rxpermissions:0.9.5 and com.github.promeg:xlog-android-idle:2.1.1.

rxpermissions

Looking on Maven Central, the only result appears to be a fork of that dependency: https://central.sonatype.com/artifact/io.github.mayampi01/com.tbruyelle.rxpermissions2.

If it's ok for you, I can change the coordinate of the dependency to the one I linked above.
But it looks like this dependency may not be used, so maybe I could simply remove it.
What do you prefer?

xlog-android-idle

For this one, there doesn't seem to be any result on Maven Central: https://central.sonatype.com/search?q=xlog-android-idle.
So I'm not sure how to move forward here.

The dependency seems to be used only in the example app, so maybe it could be removed too?

@tyvsmith
Copy link
Member

I assume both of these went down with jcenter. They both seem overkill for having in a sample app, and I don't see much/any usage.

For rxPermissions, I see none, let's kill it.

Xlog looks fine to delete too, but need the couple references stripped. Was used to support annotation based logging, I don't see any more uses of that in the app.
https://github.com/promeG/XLog

@raviagarwal7 Do you have an idea about these old deps?

@raviagarwal7
Copy link
Collaborator

Agreed, we can remove both the deps and cleanup usages if any. The deps are used in sample apps which can be simplified.

@MGaetan89
Copy link
Contributor Author

MGaetan89 commented Feb 20, 2025

Ok, I'll update the PR accordingly to remove these two dependencies.

@MGaetan89 MGaetan89 force-pushed the update_github_actions branch from 6b0359d to 1030799 Compare February 20, 2025 10:15
@MGaetan89
Copy link
Contributor Author

I've removed the two mentioned dependencies.
If you prefer that I do it in a dedicated PR, let me know.

I wasn't able to test locally if this works: after 30 min the build was still running.

@MGaetan89
Copy link
Contributor Author

I've updated my PR to use Python 3.8 in the ci.yml workflow. I've tested it on my fork, and it seems to work fine now.

A couple of notes:

  • Python 3.8 has reached end of life. Maybe the buckw script should be updated to support more recent versions.
  • The fossa.yml workflow uses fossas/fossa-cli v1, which is deprecated. It is recommended to use v3.

@MGaetan89
Copy link
Contributor Author

And now it works 🎉

@tyvsmith
Copy link
Member

Looks good, thanks for the follow-up and helping get this fixed!

@tyvsmith tyvsmith merged commit 6160366 into uber:master Feb 22, 2025
6 checks passed
@MGaetan89 MGaetan89 deleted the update_github_actions branch February 22, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants