Migrate Robolectric's deprecated code to the recommended alternatives #989
Conversation
|
|
|
It looks like the build failed downloading some dependencies. Is it possible to restart it? |
|
The build issues are being discussed here: #990 (comment) |
MGaetan89
force-pushed
the
update_robolectric
branch
from
23199d6 to
d99e229
Compare
|
I've updated my branch with the latest changes from |
|
I think I'll have to update the Java version used in the project to make this work. |
- Add `:libraries:robolectric-base` to the list of Gradle modules to load. - Add missing jUnit dependency to `:libraries:robolectric-base`. - Replace `BuckRobolectricTestRunner#getAppManifest(Config)` with `BuckRobolectricTestRunner#getManifestFactory(Config)`. The former is no longer public, and the recommended alternative is to use a custom `ManifestFactory`. - Create `BuckManifestFactory` to provide custom information for the creation of `AndroidManifest`.
MGaetan89
force-pushed
the
update_robolectric
branch
from
d99e229 to
7a8a3dd
Compare
MGaetan89
changed the title
|
I've updated this PR to just migrate deprecated code from Robolectric with the recommended alternatives. |
|
The build is successful now 🎉 |
|
Thanks @MGaetan89. Looks good, but let me do some local verification before merging. Stay tuned... And yes, we need to build Buck against JDK 17 before we can move to later versions of Robolectric. |
Description
This commit updates references to Robolectric's deprecated symbols to use the recommended alternatives.
Changes
:libraries:robolectric-baseto the list of Gradle modules to load.:libraries:robolectric-base.BuckRobolectricTestRunner#getAppManifest(Config)withBuckRobolectricTestRunner#getManifestFactory(Config). The former is no longer public, and the recommended alternative is to use a customManifestFactory.BuckManifestFactoryto provide custom information for the creation ofAndroidManifest.