-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/preview route #179
/preview route #179
Conversation
@mrudulpatil18 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is excellent, can you add a playwright test that shows that it works (and prevents others from breaking it?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok- so there's a bit of an issue. You should not have to run the code in the iframe, we should be loading circuit json that is precompiled. I believe snippet.circuit_json
can be used to get precompiled circuit json code (if not, we will want to introduce snippet.circuit_json
)
Basically if someone wants to embed a circuit on their website, their users shouldn't have to hit run.
@seveibar can you please take a look at the changes. Lots of changes through this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
* improve pcbview reloading * typefixes
Issue: #171
Changes:
<PreviewContent>
component/claim #171
cc: @seveibar