-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy tsx runner, replace with RunFrame, everything uses WebWorkers #702
Conversation
fixes #694 |
📊 Bundle Size AnalysisTotal Bundle Size
Diff
View Dependencies
What is this?This is an automated bundle size report generated during the build process. |
@@ -112,7 +88,7 @@ export function CodeAndPreview({ snippet }: Props) { | |||
snippet_id: snippet.snippet_id, | |||
code: code, | |||
dts: dts, | |||
compiled_js: compiledJs, | |||
// compiled_js: compiledJs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imrishabh18 note this is one of the biggest changes, we are no longer sending compiled_js to the server. HOWEVER, this was only needed for legacy tscircuit runners, there is now a server bundler/caching system that should eliminate the need for clients (web and cli) to compile JS or compile typescript (the dts)
Still we should be mindful that snippets saved with this will be slightly different
No description provided.