-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude specific-version docs from search engines #8016
Exclude specific-version docs from search engines #8016
Conversation
♻️ PR Preview 228ae32 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
Not sure this is the way to do it. IIUC it will remove all old versions from search engines. But what if I want to search docs for "lakectl fs 1.11"? IIUC we want to create canonical URLs for each piece of content, not remove them entirely. |
This PR will indeed cause the removal of these previous versions from search results. The current problem we're facing is that Google already considers the
It'll indeed be trickier to google for specific lakeFS versions - [Looping @keren-lakeFS here.] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SEO expert says deleting all previous versions from search engines is the way to go, so that is what we'll do.
THANKS for your patience with me here!
Closes #8008 .
Change Description
In order to exclude our version-specific docs from the search engines, this PR does two things:
/v0.*
and/v1.*
inrobots.txt
.<meta name="robots" content="noindex">
to all version folders, in build time (meaning, as part of the release actions).Another PR adds
<meta name="robots" content="noindex">
to all relevant existing html files in ourdocs-lakeFS
repo.Testing
This change will affect only the next released lakeFS version, so I'll validate it after it's released that the
<meta>
tag is added to the/v1.31/*
directory htmls (but not to the "latest" docs).After this PR will be merged, I will be able to validate that for the latest docs, it won't add this
<meta>
tag.Also, it'll be monitored with Yuval, our SEO expert.