Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noindex meta tag to existing versions #167

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

itaigilo
Copy link
Contributor

@itaigilo itaigilo commented Jul 31, 2024

Part of solving this Issue,
And related to this PR (see details there).


In this PR:

A simple search-and-replace (in IntelliJ) of:

<!-- End Google Tag Manager Head -->
<meta property="og:image" content="/v1.

With:

<!-- End Google Tag Manager Head -->
<meta name="robots" content="noindex">
<meta property="og:image" content="/v1.

(And same for /v0..)

Plus, an old debt of renaming the 0.81 dir to v0.81, and removing 0.89 (since v0.89 also exist).

That's all, no other logic.

Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR changes thousands of files. It also appears to delete a large number of files. I don't understand how to review it.

One way could be split it up. Another might be to add whatever commands / scripts you ran on the repo to the description.

@itaigilo
Copy link
Contributor Author

itaigilo commented Aug 1, 2024

This PR changes thousands of files. It also appears to delete a large number of files. I don't understand how to review it.

One way could be split it up. Another might be to add whatever commands / scripts you ran on the repo to the description.

You are totally right -
I should've done so!

I've changed the PR description.

@itaigilo itaigilo requested a review from arielshaqed August 4, 2024 11:17
Copy link
Contributor

@arielshaqed arielshaqed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think we may still be missing code in the lakeFS docs-publish workflow that will add these lines to all versions we publish in future.(?)

@itaigilo itaigilo merged commit 7f1fea9 into main Aug 5, 2024
1 check failed
@itaigilo itaigilo deleted the task/add-noindex-to-existing-versions branch August 5, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants