Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added securityContext option to each container's template #4

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

majermarci
Copy link
Contributor

Due to our CaaS security policies these must be set, so I added then in the templates.
Each container has it's designated section already in values for the containerSecurityContext, therefore I uncommented those with empty values as well.

@teichmat
Copy link

teichmat commented Feb 5, 2025

Regarding CaaS, the folder "platforms" was intended for cloud or kubernetes-version specific defaults.
However, there is nothing wrong with creating the security context settings in any k8s.

@majermarci
Copy link
Contributor Author

majermarci commented Feb 6, 2025

If you need I can add a new general values file for CaaS in platforms directory as well.
The main focus here is the addition in templates, as they were missing, so no values file could have set securityContext.

Copy link
Collaborator

@NLelekova NLelekova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just update the formatting, please :)

values.yaml Outdated
@@ -219,6 +222,9 @@ keycloak:

haproxy:
image: haproxy:2.4.0-alpine

containerSecurityContext: {}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the empty lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove them sure, just left them there for readability, as security context is not related to either the image nor the resources.

@NLelekova NLelekova merged commit 71d8163 into telekom:main Feb 12, 2025
1 check passed
@NLelekova
Copy link
Collaborator

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants