-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added securityContext option to each container's template #4
Conversation
Regarding CaaS, the folder "platforms" was intended for cloud or kubernetes-version specific defaults. |
If you need I can add a new general values file for CaaS in platforms directory as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just update the formatting, please :)
values.yaml
Outdated
@@ -219,6 +222,9 @@ keycloak: | |||
|
|||
haproxy: | |||
image: haproxy:2.4.0-alpine | |||
|
|||
containerSecurityContext: {} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove the empty lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can remove them sure, just left them there for readability, as security context is not related to either the image nor the resources.
Thank you for your contribution! |
Due to our CaaS security policies these must be set, so I added then in the templates.
Each container has it's designated section already in values for the
containerSecurityContext
, therefore I uncommented those with empty values as well.