-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file prefix options to singlepoint and geomopt #452
Conversation
Do we want to set a (partial?) default file prefix, as part of this PR or otherwise e.g. to save everything to In that case, we may want an additional option, to specify the output directory, which prepends the file prefix? Otherwise we'd lose the more descriptive part of the file prefix. |
I feel like an output directory option that doesn't affect the file name would be a good addition. I was thinking that making sure all the files work consistently with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @k-harris27!
Could you:
- Summarise the changes to how the trajectory file can now be saved (in the comments here)
- Update the CLI docs (docs/source/user_guide/command_line.rst) to make sure the example is correct
In By default, the trajectory filename is inferred from The filename can be specified manually by setting The binary .traj file written by ASE can be retained by manually setting its output path using If |
4298d07
to
d4a675b
Compare
eec3ccc
to
180d0f8
Compare
Co-authored-by: Jacob Wilkins <46597752+oerc0122@users.noreply.github.com>
180d0f8
to
ecd67e4
Compare
Adds the option to provide a file prefix that is used for all of the files produced by single point and geometry optimisations. Since this can include a directory, it helps to allow the option to create a results directory for #359 (comment).