Skip to content

Commit

Permalink
Use setdefault for dictionary defaults
Browse files Browse the repository at this point in the history
Co-authored-by: Jacob Wilkins <46597752+oerc0122@users.noreply.github.com>
  • Loading branch information
k-harris27 and oerc0122 authored Feb 28, 2025
1 parent 609f105 commit eec3ccc
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions janus_core/calculations/geom_opt.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,13 +239,11 @@ def __init__(
).absolute()

if self.write_traj:
if "filename" not in self.traj_kwargs:
self.traj_kwargs["filename"] = self._build_filename(
"traj.extxyz"
).absolute()
if "trajectory" not in self.opt_kwargs:
# Overwrite .traj binary with .extxyz by default.
self.opt_kwargs["trajectory"] = str(self.traj_kwargs["filename"])
self.traj_kwargs.setdefault(
"filename",
self._build_filename("traj.extxyz").absolute()
)
self.opt_kwargs.setdefault("trajectory", str(self.traj_kwargs["filename"]))
elif self.traj_kwargs:
raise ValueError("traj_kwargs given, but trajectory writing not enabled.")
elif "trajectory" in self.opt_kwargs:
Expand Down

0 comments on commit eec3ccc

Please sign in to comment.