chore(starknet_consensus_orchestrator): add function to await the second proposal part message

[matan-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[matan-starkware]

• chore(starknet_consensus_orchestrator): remove unused test-case dependency #4071
• chore(starknet_consensus_orchestrator): batcher can return an error from initiating a proposal #4044
• chore(starknet_consensus_orchestrator): add function to await the second proposal part message #4043 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[asmaastarkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @matan-starkware)

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 773 at r1 (raw file):

    let mut content = Vec::new();
    let deadline = tokio::time::Instant::now() + timeout;
    // Validating first proposal part, it should be fin in case this is an empty proposal,

assuming first part is the init

Suggestion:

// Validating the second proposal part, it should be fin in case this is an empty proposal,

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 886 at r1 (raw file):

                }
                x => {
                    warn!("Invalid second proposal part: {x:?}");

I agree to warn on invalid proposal parts instead of panicking 👍

[matan-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @asmaastarkware)

---

crates/starknet_consensus_orchestrator/src/sequencer_consensus_context.rs line 773 at r1 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

assuming first part is the init

I just moved the comment to the fn definition

[asmaastarkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

[matan-starkware]

Merge activity

• Feb 11, 2:27 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Feb 11, 2:27 AM EST: A user added this pull request to the GitHub merge queue with Graphite.