chore(starknet_consensus_orchestrator): remove unused test-case dependency #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
matan-starkware
changed the base branch from
matan/m15/context_supports_failed_initate_proposal
to
graphite-base/4071
matan-starkware
force-pushed
the
graphite-base/4071
branch
from
dcfd29c to
957059f
Compare
matan-starkware
force-pushed
the
matan/m15/remove_orchestrator_dependency
branch
3 times, most recently
from
7ec786f to
5c2af04
Compare
matan-starkware
force-pushed
the
matan/m15/remove_orchestrator_dependency
branch
from
5c2af04 to
0063172
Compare
asmaastarkware
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Reviewed 1 of 7 files at r1, 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)
…dency Seems the standard is to use rtest to create cases
matan-starkware
force-pushed
the
matan/m15/remove_orchestrator_dependency
branch
from
0063172 to
a6d9840
Compare
matan-starkware
commented
Feb 16, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the standard is to use rtest to create cases