Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsoDec incorporation #2442

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 46 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
8be2574
Updated to MzLib 1.0.548 and fixed custom ions in search tasks
nbollis May 21, 2024
a00af8a
reverted calibration task change
nbollis May 21, 2024
22c60ba
merged in master
nbollis May 30, 2024
f4695bb
merged in master bbbyy
nbollis Jun 10, 2024
d4f8b9d
Merge branch 'smith-chem-wisc:master' into master
nbollis Jun 19, 2024
1f0dc48
merged in master
nbollis Jun 21, 2024
5c0268b
idkman
nbollis Jul 3, 2024
b7e6a0f
merged in master
nbollis Jul 16, 2024
6446d89
Merge remote-tracking branch 'upstream/master'
nbollis Jul 24, 2024
322235d
Spectral Library from Command Line (#2386)
nbollis Jul 23, 2024
8b48c95
merged in master
nbollis Aug 6, 2024
2ef973f
Merge branch 'master' of https://github.com/nbollis/MetaMorpheus
nbollis Aug 6, 2024
0abcd9b
Merge branch 'master' of https://github.com/nbollis/MetaMorpheus
nbollis Aug 7, 2024
f9030f9
merged in master
nbollis Sep 4, 2024
046067e
merged in master
nbollis Sep 17, 2024
c38f081
Merge remote-tracking branch 'upstream/master'
nbollis Oct 3, 2024
0c04007
Merge remote-tracking branch 'upstream/master'
nbollis Oct 10, 2024
d66bf7b
Merge remote-tracking branch 'upstream/master'
Oct 18, 2024
1a4d4c0
Merge remote-tracking branch 'upstream/master'
nbollis Oct 21, 2024
c2cb244
Merge branch 'master' of https://github.com/nbollis/MetaMorpheus
nbollis Oct 21, 2024
57c4e69
Build ClassicDeconv Params View Model
Oct 26, 2024
0cef4fc
Built classic deconvolution control and the Deconvolution Host Control
Oct 26, 2024
2a73a02
Refactor deconvolution param management with ViewModel
Oct 26, 2024
1735439
Completed the first phase of the new structure. Parameters can now be…
Oct 26, 2024
4eff135
Refactor UI and add comprehensive unit tests
Oct 27, 2024
d32800c
Expanded test coverage and cleaned up code
Oct 27, 2024
fc8304d
added control to GPTMD window
Oct 27, 2024
f8d318a
Expanded test coverage
Oct 27, 2024
7aae734
Added control to the glyco and xl task windows
nbollis Oct 29, 2024
bcd7d9b
updated mzlib
nbollis Oct 31, 2024
7b59ce6
Merge branch 'DeconRefactor' into IsoDecIncorporation
nbollis Oct 31, 2024
fac130a
Adjusted IsotopicEnvelopeConstructors
nbollis Oct 31, 2024
6ea130a
Built IsoDecParamsViewModel
nbollis Oct 31, 2024
2336baf
Add IsoDecDeconvolution support and new tests
nbollis Oct 31, 2024
bef831a
added basic isodec control
nbollis Oct 31, 2024
7ca7452
Merge remote-tracking branch 'upstream/master' into IsoDecIncorporation
nbollis Oct 31, 2024
ffa77df
Add alignment properties and key handling to TextBoxControls
nbollis Oct 31, 2024
99cfa30
Add IsoDec deconvolution support and update mzLib version
nbollis Oct 31, 2024
bef7834
Added in restrictions and help text from Johnny
nbollis Nov 1, 2024
8ee8df4
Added ability to read and write decon params from toml
nbollis Nov 1, 2024
3c3f098
Styled the hell outta the controls
nbollis Nov 1, 2024
8ee16af
added isodec
nbollis Nov 21, 2024
7265c4a
Fixed Protease bug and removed many mono iso from decon options
nbollis Dec 4, 2024
2d8622a
Merged in Master
nbollis Jan 13, 2025
bc471d4
Refactor ViewModel classes and update unit tests
nbollis Jan 14, 2025
a75544d
Expanded test coverage
nbollis Jan 14, 2025
e0a44a1
Added default charge states for isodec
nbollis Jan 17, 2025
4fa970c
Merge branch 'master' into IsoDecIncorporation
nbollis Jan 23, 2025
7955af6
Added decon choice to calibration
nbollis Jan 28, 2025
86bf59a
Merge branch 'IsoDecIncorporation' of https://github.com/nbollis/Meta…
nbollis Jan 28, 2025
8252d05
Merge branch 'master' into IsoDecIncorporation
nbollis Jan 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MetaMorpheus/EngineLayer/CommonParameters.cs
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ public int DeconvolutionMaxAssumedChargeState
get => PrecursorDeconvolutionParameters.MaxAssumedChargeState;
private set => PrecursorDeconvolutionParameters.MaxAssumedChargeState = value;
}
[TomlIgnore] public DeconvolutionParameters PrecursorDeconvolutionParameters { get; private set; }
[TomlIgnore] public DeconvolutionParameters ProductDeconvolutionParameters { get; private set; }
public DeconvolutionParameters PrecursorDeconvolutionParameters { get; private set; }
public DeconvolutionParameters ProductDeconvolutionParameters { get; private set; }
[TomlIgnore] public Tolerance DeconvolutionMassTolerance { get; private set; }
public int TotalPartitions { get; set; }
public Tolerance ProductMassTolerance { get; set; } // public setter required for calibration task
Expand Down
4 changes: 3 additions & 1 deletion MetaMorpheus/GUI/TaskWindows/GPTMDTaskWindow.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,9 @@ private void ProteaseSpecificUpdate(object sender, SelectionChangedEventArgs e)
if (UpdateGUISettings.UseTopDownRecommendedSettings())
{
DeconHostViewModel.UseProvidedPrecursors = false;
DeconHostViewModel.PrecursorDeconvolutionParameters.MaxAssumedChargeState = 60;
DeconHostViewModel.DoPrecursorDeconvolution = true;
DeconHostViewModel.SetAllPrecursorMaxChargeState(60);
DeconHostViewModel.SetAllProductMaxChargeState(20);
TrimMsMs.IsChecked = false;
//uncheck all variable mods
foreach (var mod in VariableModTypeForTreeViewObservableCollection)
Expand Down
6 changes: 4 additions & 2 deletions MetaMorpheus/GUI/TaskWindows/SearchTaskWindow.xaml.cs
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ private void UpdateFieldsFromTask(SearchTask task)
DeconHostViewModel = new DeconHostViewModel(TheTask.CommonParameters.PrecursorDeconvolutionParameters,
TheTask.CommonParameters.ProductDeconvolutionParameters,
TheTask.CommonParameters.UseProvidedPrecursorInfo, TheTask.CommonParameters.DoPrecursorDeconvolution);
DeisotopingControl.DataContext = DeconHostViewModel;

NumberOfPeaksToKeepPerWindowTextBox.Text = task.CommonParameters.NumberOfPeaksToKeepPerWindow == int.MaxValue || !task.CommonParameters.NumberOfPeaksToKeepPerWindow.HasValue ? "" : task.CommonParameters.NumberOfPeaksToKeepPerWindow.Value.ToString(CultureInfo.InvariantCulture);
MinimumAllowedIntensityRatioToBasePeakTexBox.Text = task.CommonParameters.MinimumAllowedIntensityRatioToBasePeak == double.MaxValue || !task.CommonParameters.MinimumAllowedIntensityRatioToBasePeak.HasValue ? "" : task.CommonParameters.MinimumAllowedIntensityRatioToBasePeak.Value.ToString(CultureInfo.InvariantCulture);
Expand Down Expand Up @@ -428,7 +429,6 @@ private void SaveButton_Click(object sender, RoutedEventArgs e)
CleavageSpecificity searchModeType = GetSearchModeType(); //change search type to semi or non if selected
SnesUpdates(searchModeType); //decide on singleN/C, make comp ion changes

// TODO: Reconcile Isodec params with Mass difference acceptor
if (!GlobalGuiSettings.CheckTaskSettingsValidity(
PrecursorMassToleranceTextBox.Text,
ProductMassToleranceTextBox.Text,
Expand Down Expand Up @@ -892,7 +892,9 @@ private void ProteaseSpecificUpdate(object sender, SelectionChangedEventArgs e)
if (UpdateGUISettings.UseTopDownRecommendedSettings())
{
DeconHostViewModel.DoPrecursorDeconvolution = true;
DeconHostViewModel.PrecursorDeconvolutionParameters.MaxAssumedChargeState = 60;
DeconHostViewModel.UseProvidedPrecursors = false;
DeconHostViewModel.SetAllPrecursorMaxChargeState(60);
DeconHostViewModel.SetAllProductMaxChargeState(20);
TrimMsMs.IsChecked = false;
CheckBoxNoQuant.IsChecked = true;
MassDiffAccept3mm.IsChecked = true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ public override object Convert(object value, Type targetType, object parameter,
{
case DeconvolutionType.ClassicDeconvolution:
return new ClassicDeconParamsControl() { DataContext = value as ClassicDeconParamsViewModel };
case DeconvolutionType.IsoDecDeconvolution:
return new IsoDecDeconParamControl() { DataContext = value as IsoDecDeconParamsViewModel };

case DeconvolutionType.ExampleNewDeconvolutionTemplate:
default:
Expand Down
50 changes: 33 additions & 17 deletions MetaMorpheus/GUI/Views/Deconvolution/HostDeconParamControl.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
</Style>
</UserControl.Resources>

<GroupBox Header="Deisotoping" >
<GroupBox Header="MS1 Deconvolution" >
<Grid d:DataContext="{x:Static guiFunctions:DeconHostModel.Instance}">

<Grid.RowDefinitions>
Expand Down Expand Up @@ -66,7 +66,7 @@
</StackPanel>

<!-- Deconvolute precursors -->
<StackPanel Orientation="Horizontal" Margin="10,5,5,5">
<StackPanel Orientation="Horizontal" Margin="10,10,5,5">
<CheckBox x:Name="DeconvolutePrecursors" Content="Deconvolute Precursors"
IsChecked="{Binding DoPrecursorDeconvolution}" ToolTipService.ShowDuration="999999"
ToolTipService.InitialShowDelay="500">
Expand All @@ -79,13 +79,13 @@
</StackPanel>
</StackPanel>

<!-- Decon Type ComboBox -->
<ComboBox Grid.Column="1" x:Name="DeconvolutionTypeComboBox" Width="140" Height="35"
<!-- Precursor Decon Type ComboBox -->
<ComboBox Grid.Column="1" x:Name="DeconvolutionTypeComboBox" Width="100" Height="35"
VerticalContentAlignment="Center" HorizontalContentAlignment="Center"
ItemsSource="{Binding PrecursorDeconvolutionParametersList}"
SelectedItem="{Binding PrecursorDeconvolutionParameters}"
ToolTipService.ShowDuration="999999" ToolTipService.InitialShowDelay="500"
Visibility="{Binding DisplayDeconSelectionComboBox, Converter={StaticResource BooleanToVisibilityConverter}}">
Visibility="{Binding DisplayDeconSelectionComboBox, Converter={StaticResource BooleanToVisibilityConverter}}"
ToolTipService.ShowDuration="999999" ToolTipService.InitialShowDelay="500">
<ComboBox.ToolTip>
<TextBlock>
The type of deconvolution to perform.
Expand All @@ -95,18 +95,34 @@
</Grid>

<!-- Specific Precursor Parameters -->
<ItemsControl Grid.Row="1" Margin="5"
ItemsSource="{Binding PrecursorDeconvolutionParametersList}">
<ItemsControl.ItemTemplate>
<DataTemplate>
<ContentControl
Content="{
Binding RelativeSource={RelativeSource AncestorType=Grid, Mode=FindAncestor},
Path=DataContext.PrecursorDeconvolutionParameters,
<ContentControl Grid.Row="1" Margin="5" Content="{
Binding PrecursorDeconvolutionParameters,
Converter={StaticResource DeconTypeToControlConverter }}" />
</DataTemplate>
</ItemsControl.ItemTemplate>
</ItemsControl>

<!-- Specific Product Parameters -->
<Expander Grid.Row="2" Header="MS2 Deconvolution" >
<Border BorderBrush="{StaticResource BorderColor}" BorderThickness="1" CornerRadius="10">
<StackPanel>
<ComboBox x:Name="ProductDeconvolutionTypeComboBox" Width="100" Height="35" Margin="5 5 5 -5"
VerticalContentAlignment="Center" HorizontalContentAlignment="Center" HorizontalAlignment="Right"
ItemsSource="{Binding ProductDeconvolutionParametersList}"
SelectedItem="{Binding ProductDeconvolutionParameters}"
Visibility="{Binding DisplayDeconSelectionComboBox, Converter={StaticResource BooleanToVisibilityConverter}}"
ToolTipService.ShowDuration="999999" ToolTipService.InitialShowDelay="500" >
<ComboBox.ToolTip>
<TextBlock>
The type of deconvolution to perform.
</TextBlock>
</ComboBox.ToolTip>
</ComboBox>

<ContentControl Margin="5" Content="{
Binding ProductDeconvolutionParameters,
Converter={StaticResource DeconTypeToControlConverter }}" />
</StackPanel>

</Border>
</Expander>
</Grid>
</GroupBox>
</UserControl>
Loading
Loading