-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch all LP user data #6032
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
ada4b06
to
82fd4e3
Compare
b93ce8c
to
389668e
Compare
389668e
to
ad53095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First functional note before I review the code is that this PR causes my RUNE aysm LPs to not show anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love me some skeletons, though we lose our RUNE asymmetrical pools in the PR.
c62f177
to
600c12e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm now seeing all LP positions 🙏
Description
i.e iterates over all pool AssetIds, and iterates over all AssetId AccountIds to fetch user data.
This allows us to have a proper loading state for "Your Positions".
Pull Request Type
Issue (if applicable)
N/A
Risk
Low, ensure pools still function as before
Testing
This can be tested with throttling to reliably test this in case things are too fast
Engineering
Operations
Screenshots (if applicable)
loady.mov