Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fetch all LP user data #6032

Merged
merged 9 commits into from
Jan 19, 2024
Merged

feat: fetch all LP user data #6032

merged 9 commits into from
Jan 19, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 17, 2024

Description

i.e iterates over all pool AssetIds, and iterates over all AssetId AccountIds to fetch user data.

This allows us to have a proper loading state for "Your Positions".

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A

Risk

Low, ensure pools still function as before

Testing

  • Loading state for "Your Positions" is now happy
    • Initially skeletons
    • As some but not all are loaded, the loaded positions are displayed but skeletons are still concatenated while others are still loading
    • Skeletons are gone after all are loaded

This can be tested with throttling to reliably test this in case things are too fast

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

loady.mov

Copy link
Contributor Author

gomesalexandre commented Jan 17, 2024

@gomesalexandre gomesalexandre changed the title wip: fetch all LP user data feat: fetch all LP user data Jan 17, 2024
@gomesalexandre gomesalexandre force-pushed the feat_wire_up_confirmed_quote branch 2 times, most recently from ada4b06 to 82fd4e3 Compare January 17, 2024 22:48
@gomesalexandre gomesalexandre marked this pull request as ready for review January 17, 2024 22:48
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 17, 2024 22:48
Base automatically changed from feat_wire_up_confirmed_quote to develop January 17, 2024 22:55
@0xApotheosis 0xApotheosis self-assigned this Jan 17, 2024
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First functional note before I review the code is that this PR causes my RUNE aysm LPs to not show anymore.

Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love me some skeletons, though we lose our RUNE asymmetrical pools in the PR.

@gomesalexandre
Copy link
Contributor Author

Love me some skeletons, though we lose our RUNE asymmetrical pools in the PR.

This should be happy now!

image
  • RUNE fix: 81b688c
  • Naive deduplication which was needed following the RUNE fix 36d2afd
  • Less naive deduplication with multi-account future-proofing: 62a8917

@gomesalexandre gomesalexandre mentioned this pull request Jan 18, 2024
3 tasks
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now seeing all LP positions 🙏

@0xApotheosis 0xApotheosis merged commit ce65093 into develop Jan 19, 2024
@0xApotheosis 0xApotheosis deleted the feat_lp_loading_states branch January 19, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants