Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: wire-up confirmed "Add Liquidity" quote #6030

Merged
merged 7 commits into from
Jan 17, 2024
Merged

feat: wire-up confirmed "Add Liquidity" quote #6030

merged 7 commits into from
Jan 17, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 17, 2024 •
edited
Loading

Description

Wires up the quote in confirm and status screens, bringing in the notion of "confirmed quote".

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #6019

Risk

None

Testing

  • Ensure the confirmed quote data is propagated over confirm and status screens

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

Pool Page

RUNE asym

image image image image

Asset asym

image image image

Symmetrical

image image image

Add Liquidity Page

RUNE asym

image image

Asset asym

image image image

Symmetrical

image image image

@gomesalexandre gomesalexandre mentioned this pull request Jan 17, 2024
Merged
3 tasks
@gomesalexandre Graphite App
Copy link
Contributor Author

gomesalexandre commented Jan 17, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre changed the title wip: wire-up confirmed quote wip: wire-up confirmed "Add Liquidity" quote Jan 17, 2024
@gomesalexandre gomesalexandre changed the title wip: wire-up confirmed "Add Liquidity" quote feat: wire-up confirmed "Add Liquidity" quote Jan 17, 2024
@gomesalexandre gomesalexandre marked this pull request as ready for review January 17, 2024 17:30
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 17, 2024 17:30
@gomesalexandre gomesalexandre mentioned this pull request Jan 17, 2024
Merged
3 tasks
@0xApotheosis 0xApotheosis self-assigned this Jan 17, 2024
Base automatically changed from feat_standalone_add_liquidity to develop January 17, 2024 22:28
@gomesalexandre gomesalexandre force-pushed the feat_wire_up_confirmed_quote branch from adb9ff0 to ada4b06 Compare January 17, 2024 22:47
@gomesalexandre gomesalexandre force-pushed the feat_wire_up_confirmed_quote branch from ada4b06 to 82fd4e3 Compare January 17, 2024 22:48
0xApotheosis
0xApotheosis approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what is says on the box 👌

@0xApotheosis 0xApotheosis enabled auto-merge (squash) January 17, 2024 22:51
@0xApotheosis 0xApotheosis disabled auto-merge January 17, 2024 22:55
@0xApotheosis 0xApotheosis merged commit f04405c into develop Jan 17, 2024
@0xApotheosis 0xApotheosis deleted the feat_wire_up_confirmed_quote branch January 17, 2024 22:55
@0xApotheosis 0xApotheosis mentioned this pull request Jan 18, 2024
Merged
This was referenced Jan 18, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees

@0xApotheosis 0xApotheosis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get quote for add / rem liquidity and add to ui component
2 participants
@gomesalexandre @0xApotheosis