You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Long tail swaps don't correctly enforce slippage leading to sandwich and a loss of user funds. We need to resolve this and additionally take the time to audit anywhere else this might be the case and confirm slippage is set correctly.
AC
Long tail swaps correctly enforce a minAmountOut for the intermediary asset
All other swap protocols / routes are confirmed to enforce sane slippage tolerances
The text was updated successfully, but these errors were encountered:
In addition to the long-tail fixes above, I sanity checked the following at runtime:
1inch:
We correctly build the transaction payload with the user's specified slippage (or the default if not set) in the slippage parameter:
0x
We only use the user's specified slippage if 0x supports slippage protection for that trade pair. If not, we default to 0.2% (and let the user know that custom slippage is not supported).
THORChain
For non-streaming swaps we use a param in the memo to set the minimum amount out before the trade will be reverted (based on the slippage value - custom or default).
Long tail swaps don't correctly enforce slippage leading to sandwich and a loss of user funds. We need to resolve this and additionally take the time to audit anywhere else this might be the case and confirm slippage is set correctly.
AC
minAmountOut
for the intermediary assetThe text was updated successfully, but these errors were encountered: