Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: long tail explorer Tx link #6069

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix: long tail explorer Tx link #6069

merged 2 commits into from
Jan 24, 2024

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Jan 24, 2024 •
edited
Loading

Description

Fixes wrong Txid link for long-tail THOR Txs, following up on #6067

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Relates to #6017

Risk

High Risk PRs Require 2 approvals

None

Testing

  • Long-tail Tx links are happy i.e aren't prefixed with the EVM 0x prefix

Engineering

  • ☝🏽

Operations

  • ☝🏽

Screenshots (if applicable)

  • Develop
Screenshot 2024-01-24 at 11 57 12 Screenshot 2024-01-24 at 11 57 32
  • This diff

Happy Tx link 🎉

image Screenshot 2024-01-24 at 11 57 46

@gomesalexandre Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@gomesalexandre gomesalexandre marked this pull request as ready for review January 24, 2024 11:03
@gomesalexandre gomesalexandre requested a review from a team as a code owner January 24, 2024 11:03
0xApotheosis
0xApotheosis approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch, the new labels broke that! 🙏

@0xApotheosis 0xApotheosis merged commit c4b9e22 into develop Jan 24, 2024
4 checks passed
@0xApotheosis 0xApotheosis deleted the fix_long_tail_txid branch January 24, 2024 19:37
@0xApotheosis 0xApotheosis mentioned this pull request Jan 25, 2024
Merged
0xApotheosis pushed a commit that referenced this pull request Jan 25, 2024
@gomesalexandre @0xApotheosis
fix: long tail explorer Tx link (#6069)
29d47ff
@gomesalexandre gomesalexandre mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @0xApotheosis