Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove redundant throw #6058

Merged
merged 2 commits into from
Jan 23, 2024
Merged

chore: remove redundant throw #6058

merged 2 commits into from
Jan 23, 2024

Conversation

0xApotheosis
Copy link
Member

Description

I added this in 3c5c907, but it's actually redundant and already covered by the line:

assert(amountOutMin > 0n, 'expected expectedAmountOut to be be a positive amount')

Pull Request Type

  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
  • 💅 New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

Related to #6017

Risk

Low

Testing

THORChain quotes and error messages for longtail and non-longtail should still work as expected.

Engineering

☝️

Operations

☝️

Screenshots (if applicable)

N/A

@0xApotheosis 0xApotheosis requested a review from a team as a code owner January 23, 2024 01:20
@0xApotheosis 0xApotheosis enabled auto-merge (squash) January 23, 2024 01:21
@0xApotheosis 0xApotheosis merged commit 83fe4ab into develop Jan 23, 2024
3 checks passed
@0xApotheosis 0xApotheosis deleted the remove-redundent-throw branch January 23, 2024 02:53
@0xApotheosis 0xApotheosis mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodenfurniture woodenfurniture woodenfurniture approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xApotheosis @woodenfurniture