-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to disable runner updates #108
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! The changes look great. One thing I wonder about, though, is whether we should add some explanatory text in the UI to clarify what this setting does. Even with this enabled, new versions of the runner will still be downloaded when the VM reboots, as it always fetches the latest version at that point. I worry that "Disable runner auto-update" might be misleading. What do you think? |
Damn, I didn't think about that... |
@kuhnroyal If all you're interested in is making sure Tartelet never updates the runner, even between reboots of the virtual machine, then you should edit the virtual machine, copy in the runner archive, and extract it. This part of the shell script ensures that the runner script is only downloaded if |
That's actually a good idea, will check if I can adapt my build. |
Ok, I have a preinstalled runner version and it automatically updates when the runner launches. |
5d17c51
to
064ab5c
Compare
I couldn't test the config.sh changes since I can't get Tartelet to save my PEM key, everything else is being saved... |
@kuhnroyal Thanks for adding the texts.
Have you looked at the comments in #2 and #86? Both issues describe similar problems with proposed workarounds. |
Description
Disable automatic updates of the Github runner
Motivation and Context
Closes #107
Screenshots (if appropriate):
Types of changes