Add options to disable runner updates

shapehq · Feb 3, 2025 · 5d17c51 · 5d17c51
1 parent e6bcb76
commit 5d17c51
Show file tree

Hide file tree

Showing 8 changed files with 29 additions and 1 deletion.
diff --git a/Packages/Settings/Sources/SettingsData/AppStorageSettingsStore.swift b/Packages/Settings/Sources/SettingsData/AppStorageSettingsStore.swift
@@ -11,6 +11,7 @@ public final class AppStorageSettingsStore: SettingsStore {
         static let numberOfVirtualMachines = "numberOfVirtualMachines"
         static let startVirtualMachinesOnLaunch = "startVirtualMachinesOnLaunch"
         static let gitHubPrivateKeyName = "gitHubPrivateKeyName"
+        static let gitHubRunnerDisableUpdates = "gitHubRunnerDisableUpdates"
         static let gitHubRunnerLabels = "gitHubRunnerLabels"
         static let gitHubRunnerGroup = "gitHubRunnerGroup"
         static let githubRunnerScope = "githubRunnerScope"
@@ -91,6 +92,17 @@ public final class AppStorageSettingsStore: SettingsStore {
             }
         }
     }
+    public var gitHubRunnerDisableUpdates: Bool {
+        get {
+            access(keyPath: \.gitHubRunnerDisableUpdates)
+            return userDefaults.bool(forKey: AppStorageKey.gitHubRunnerDisableUpdates)
+        }
+        set {
+            withMutation(keyPath: \.gitHubRunnerDisableUpdates) {
+                userDefaults.setValue(newValue, forKey: AppStorageKey.gitHubRunnerDisableUpdates)
+            }
+        }
+    }
     public var gitHubRunnerLabels: String {
         get {
             access(keyPath: \.gitHubRunnerLabels)

diff --git a/Packages/Settings/Sources/SettingsDomain/SettingsStore.swift b/Packages/Settings/Sources/SettingsDomain/SettingsStore.swift
@@ -8,6 +8,7 @@ public protocol SettingsStore: AnyObject {
     var numberOfVirtualMachines: Int { get set }
     var startVirtualMachinesOnLaunch: Bool { get set }
     var gitHubPrivateKeyName: String? { get set }
+    var gitHubRunnerDisableUpdates: Bool { get set }
     var gitHubRunnerLabels: String { get set }
     var gitHubRunnerGroup: String { get set }
     var githubRunnerScope: GitHubRunnerScope { get set }

diff --git a/.../Settings/Sources/SettingsUI/Internal/GitHubRunnerSettings/GitHubRunnerSettingsView.swift b/.../Settings/Sources/SettingsUI/Internal/GitHubRunnerSettings/GitHubRunnerSettingsView.swift
@@ -26,6 +26,13 @@ struct GitHubRunnerSettingsView<SettingsStoreType: SettingsStore & Observable>:
                 )
                 .disabled(!isSettingsEnabled)
             }
+            Section {
+                Toggle(
+                    L10n.Settings.GithubRunner.disableUpdates,
+                    isOn: $settingsStore.gitHubRunnerDisableUpdates
+                )
+                .disabled(!isSettingsEnabled)
+            }
         }
         .formStyle(.grouped)
     }

diff --git a/Packages/Settings/Sources/SettingsUI/Internal/L10n.swift b/Packages/Settings/Sources/SettingsUI/Internal/L10n.swift
@@ -85,6 +85,8 @@ internal enum L10n {
       }
     }
     internal enum GithubRunner {
+      /// Auto-update
+      internal static let disableUpdates = L10n.tr("Localizable", "settings.github_runner.disableUpdates", fallback: "Disable runner auto-update")
       /// Group
       internal static let group = L10n.tr("Localizable", "settings.github_runner.group", fallback: "Group")
       /// Labels

diff --git a/Packages/Settings/Sources/SettingsUI/Internal/Localizable.strings b/Packages/Settings/Sources/SettingsUI/Internal/Localizable.strings
@@ -41,6 +41,7 @@
 "settings.github.create_app" = "Create GitHub App";
 
 "settings.github_runner" = "Runner";
+"settings.github_runner.disableUpdates" = "Disable runner auto-update";
 "settings.github_runner.labels" = "Labels";
 "settings.github_runner.labels.prompt" = "comma,separated,list";
 "settings.github_runner.labels.footer" = "Comma-separated list of labels.";

diff --git a/...e/Sources/VirtualMachineDomain/GitHubActionsRunner/GitHubActionsRunnerConfiguration.swift b/...e/Sources/VirtualMachineDomain/GitHubActionsRunner/GitHubActionsRunnerConfiguration.swift
@@ -1,6 +1,7 @@
 import GitHubDomain
 
 public protocol GitHubActionsRunnerConfiguration {
+    var runnerDisableUpdates: Bool { get }
     var runnerScope: GitHubRunnerScope { get }
     var runnerLabels: String { get }
     var runnerGroup: String { get }

diff --git a/...es/VirtualMachineDomain/GitHubActionsRunner/GitHubActionsRunnerSSHConnectionHandler.swift b/...es/VirtualMachineDomain/GitHubActionsRunner/GitHubActionsRunnerSSHConnectionHandler.swift
@@ -107,7 +107,8 @@ cd \\$ACTIONS_RUNNER_DIRECTORY
   --name "\(virtualMachine.name)"\\\\
   --runnergroup "\(configuration.runnerGroup)"\\\\
   --work "_work"\\\\
-  --token "\(runnerToken.rawValue)"
+  --token "\(runnerToken.rawValue)"\\\\
+  \(configuration.runnerDisableUpdates ? "--disableUpdates" : "")
 ./run.sh
 EOF
 """)

diff --git a/Tartelet/Sources/SettingsGitHubActionsRunnerConfiguration.swift b/Tartelet/Sources/SettingsGitHubActionsRunnerConfiguration.swift
@@ -6,6 +6,9 @@ struct SettingsGitHubActionsRunnerConfiguration<
     SettingsStoreType: SettingsStore
 >: GitHubActionsRunnerConfiguration {
     let settingsStore: SettingsStoreType
+    var runnerDisableUpdates: Bool {
+        settingsStore.gitHubRunnerDisableUpdates
+    }
     var runnerScope: GitHubRunnerScope {
         settingsStore.githubRunnerScope
     }