Enable all pending cops #1902
Merged
Enable all pending cops #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
force-pushed
the
enable-pending-cops
branch
from
e1f1078 to
21ebc53
Compare
|
@ydah The Danger check failed, and I’m not sure why. Could you have a look, please? |
pirj
approved these changes
Jun 3, 2024
|
@Darhazer Any comments? |
|
Let’s remember https://metaredux.com/posts/2020/06/08/the-rubocop-name-drama-redux.html and not get too crazy with the police/cop analogy 😬 I asked @Darhazer for feedback only about an hour ago, so I’ll leave this PR open until tomorrow where I’ll merge and make a pre-release. See also #1880 (comment) |
|
I admit I had a few more funny phrases to add to that comment, but removed them before sending. |
bquorning
force-pushed
the
enable-pending-cops
branch
from
21ebc53 to
1af0b78
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1886
When a new cop is added, its state is
pending. The only time we enable cops is when we make a major release. v3.0 is just around the corner, so now we enable the pending cops.Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).